ref: Remove SentrySerializable on user

[noahsmartin]

I couldn't quite keep the existing V9 code because they failed the cocoapods build. But with these changes to use the function name instead of the protocol it compiles in all cases and makes this internal implementation detail not part of the public API

#skip-changelog

Closes #6529

[codecov]

Codecov Report

❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.336%. Comparing base (827b50c) to head (a6a458c).
⚠️ Report is 8 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
Sources/Sentry/SentryPublicSerializer.m	0.000%	8 Missing ⚠️
Sources/Sentry/SentryCrashScopeObserver.m	0.000%	5 Missing ⚠️
...Integrations/SessionReplay/SentryReplayEvent.swift	0.000%	3 Missing ⚠️
...ources/Swift/Helper/SentrySerializationSwift.swift	0.000%	2 Missing ⚠️
Sources/Swift/Tools/SentryEnvelopeItem.swift	0.000%	2 Missing ⚠️
Sources/Sentry/SentryFileManagerHelper.m	0.000%	1 Missing ⚠️
Sources/Sentry/SentryTransaction.m	0.000%	1 Missing ⚠️
.../Persistence/SentryScopePersistentStore+User.swift	0.000%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (827b50c) and HEAD (a6a458c). Click for more details.

HEAD has 3 uploads less than BASE

Flag	BASE (827b50c)	HEAD (a6a458c)
	4	1

Additional details and impacted files

@@              Coverage Diff              @@
##              main    #6528        +/-   ##
=============================================
- Coverage   86.492%   7.336%   -79.157%     
=============================================
  Files          451      417        -34     
  Lines        27488    26117      -1371     
  Branches     11970     9631      -2339     
=============================================
- Hits         23775     1916     -21859     
- Misses        3667    24190     +20523     
+ Partials        46       11        -35     

Files with missing lines	Coverage Δ
Sources/Sentry/SentryEvent.m	8.163% <ø> (-90.817%)	⬇️
Sources/Sentry/SentryScope.m	8.759% <ø> (-88.322%)	⬇️
Sources/Swift/Helper/SentrySdkInfo.swift	0.000% <ø> (-100.000%)	⬇️
...rations/SessionReplay/RRWeb/SentryRRWebEvent.swift	0.000% <ø> (-100.000%)	⬇️
...ift/Integrations/UserFeedback/SentryFeedback.swift	0.000% <ø> (-74.419%)	⬇️
Sources/Swift/SentryAppState.swift	0.000% <ø> (-95.946%)	⬇️
Sources/Swift/Tools/SentryClientReport.swift	0.000% <ø> (-100.000%)	⬇️
Sources/Swift/Tools/SentryDiscardedEvent.swift	0.000% <ø> (-100.000%)	⬇️
Sources/Sentry/SentryFileManagerHelper.m	17.040% <0.000%> (-71.077%)	⬇️
Sources/Sentry/SentryTransaction.m	10.294% <0.000%> (-79.412%)	⬇️
... and 6 more

... and 420 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 827b50c...a6a458c. Read the comment docs.

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1225.76 ms	1260.12 ms	34.36 ms
Size	23.75 KiB	1.00 MiB	1001.99 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
7629df7	1224.80 ms	1250.29 ms	25.49 ms
db9572a	1223.13 ms	1241.60 ms	18.47 ms
76f74df	1238.29 ms	1261.22 ms	22.94 ms
9450cb4	1221.29 ms	1232.96 ms	11.67 ms
701b301	1226.10 ms	1245.57 ms	19.47 ms
079bcc8	1217.88 ms	1234.88 ms	17.00 ms
fdea6f5	1216.08 ms	1241.82 ms	25.73 ms
c30e401	1218.71 ms	1243.73 ms	25.02 ms
934eee4	1222.51 ms	1251.04 ms	28.53 ms
aa96485	1215.37 ms	1234.04 ms	18.67 ms

App size

Revision	Plain	With Sentry	Diff
7629df7	23.75 KiB	959.45 KiB	935.70 KiB
db9572a	23.75 KiB	858.64 KiB	834.89 KiB
76f74df	23.75 KiB	879.61 KiB	855.86 KiB
9450cb4	23.75 KiB	908.55 KiB	884.80 KiB
701b301	23.75 KiB	867.16 KiB	843.41 KiB
079bcc8	23.74 KiB	874.07 KiB	850.33 KiB
fdea6f5	23.75 KiB	867.15 KiB	843.40 KiB
c30e401	23.74 KiB	971.70 KiB	947.96 KiB
934eee4	23.75 KiB	988.03 KiB	964.28 KiB
aa96485	23.75 KiB	874.46 KiB	850.71 KiB

Previous results on branch: removeSentryUserSerializeable

Startup times

Revision	Plain	With Sentry	Diff
dfaa1b6	1224.78 ms	1254.31 ms	29.54 ms
2334424	1217.19 ms	1252.83 ms	35.64 ms

App size

Revision	Plain	With Sentry	Diff
dfaa1b6	23.75 KiB	1.00 MiB	1005.08 KiB
2334424	23.75 KiB	1.00 MiB	1005.04 KiB

[noahsmartin]

This isn't working with the cocoapods build so I'm going to convert it back to draft for now