fix: Disable SessionSentryReplayIntegration if the environment is unsafe #6539
+85
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Fixes
- Disable SessionSentryReplayIntegration if the environment is unsafe ([#6539](https://github.com/getsentry/sentry-cocoa/pull/6539))If none of the above apply, you can opt out of this check by adding |
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
noahsmartin
reviewed
Oct 24, 2025
| @objc public static let processInfoWrapper: SentryProcessInfoSource = ProcessInfo.processInfo | ||
| static let infoPlistWrapper: SentryInfoPlistWrapperProvider = SentryInfoPlistWrapper() | ||
| @objc public static let sessionReplayEnvironmentChecker: SentrySessionReplayEnvironmentChecker = { | ||
| @objc public static var sessionReplayEnvironmentChecker: SentrySessionReplayEnvironmentCheckerProvider = { |
There was a problem hiding this comment.
Only a let is thread safe. If you need it to override the value for testing I think it's better to pass the dependencies as a parameter to the class you're testing, rather than having it used from here.
Or if that's too hard to refactor just move it to SentryDependencyContainer and use the lock with a lazy var
There was a problem hiding this comment.
This is only for testing.
Moving this to SentryDependencyContainer won't work on the v8 branch, which also needs this fix
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| db9572a | 1200.27 ms | 1234.80 ms | 34.53 ms |
| 5258fb8 | 1207.92 ms | 1234.51 ms | 26.59 ms |
| 2481950 | 1221.04 ms | 1248.98 ms | 27.94 ms |
| 2be5991 | 1228.55 ms | 1264.65 ms | 36.10 ms |
| 7d88965 | 1228.86 ms | 1248.53 ms | 19.67 ms |
| ab0ba7e | 1216.08 ms | 1242.40 ms | 26.31 ms |
| 139db8b | 1231.50 ms | 1258.19 ms | 26.69 ms |
| 78af7a9 | 1225.75 ms | 1256.98 ms | 31.23 ms |
| 5db87fa | 1218.88 ms | 1251.53 ms | 32.65 ms |
| b5a7583 | 1238.22 ms | 1263.94 ms | 25.71 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| db9572a | 23.75 KiB | 858.69 KiB | 834.93 KiB |
| 5258fb8 | 23.75 KiB | 874.45 KiB | 850.70 KiB |
| 2481950 | 23.74 KiB | 872.74 KiB | 849.00 KiB |
| 2be5991 | 23.75 KiB | 994.73 KiB | 970.98 KiB |
| 7d88965 | 23.75 KiB | 994.72 KiB | 970.98 KiB |
| ab0ba7e | 23.75 KiB | 904.54 KiB | 880.79 KiB |
| 139db8b | 23.75 KiB | 920.64 KiB | 896.89 KiB |
| 78af7a9 | 23.75 KiB | 990.00 KiB | 966.26 KiB |
| 5db87fa | 23.75 KiB | 926.65 KiB | 902.90 KiB |
| b5a7583 | 23.75 KiB | 913.44 KiB | 889.68 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disable the SessionReplayIntegration instead of disabling SentrySessionReplay to avoid running any SessionReplay logic if not needed.