Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Sentry Cocoa 8.36.0 #352

Merged
merged 6 commits into from
Oct 4, 2024
Merged

Bump Sentry Cocoa 8.36.0 #352

merged 6 commits into from
Oct 4, 2024

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Oct 1, 2024

This PR Bumps Sentry cocoa dependency from version 8.21.0 to version 8.36.0.

No break changes were introduced and the app is building with this version locally.

@lucas-zimerman lucas-zimerman marked this pull request as ready for review October 1, 2024 14:02
CHANGELOG.md Outdated Show resolved Hide resolved
Comment on lines +76 to +78

# Yalc
sample/yalc.lock
Copy link
Member

@krystofwoldrich krystofwoldrich Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L: Should we delete the yalc.lock from the sample project? As at the moment it's still tracked in git.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, makes sense, I will delete it

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG 🚀

Just one non blocking comment about Yalc.

@lucas-zimerman lucas-zimerman merged commit 6445e67 into main Oct 4, 2024
6 checks passed
@lucas-zimerman lucas-zimerman deleted the bump/cocoa branch October 4, 2024 12:51
Copy link

github-actions bot commented Oct 4, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.
Example:

## Unreleased

### Fixes/Features

- Bump Sentry Cocoa 8.36.0 ([#352](https://github.com/getsentry/sentry-cordova/pull/352))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 3e895a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants