Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: capture touch breadcrumbs for all buttons #2242

Merged
merged 16 commits into from
Sep 9, 2024

Merge branch 'main' into feat/capture-touch-breadcrumbs

b58b91d
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: capture touch breadcrumbs for all buttons #2242

Merge branch 'main' into feat/capture-touch-breadcrumbs
b58b91d
Select commit
Loading
Failed to load commit list.
GitHub Actions / Analysis of sentry succeeded Sep 9, 2024 in 54s

Package analysis results for sentry

Score

140/160 points
(87.5%)

Supported platforms

  • Flutter
    • android
    • ios
    • windows
    • linux
    • macos
    • web
  • Dart
    • native-aot
      Can be aot compiled with eg. dart2native (Can use dart:io but not dart:mirrors)
    • native-jit
      Can be run with the dart vm in jit mode. (Can use dart:io and dart:mirrors)
    • web
      Can be compiled with DDC and dart2js. (Can use dart:html and friends, not dart:io, dart:mirrors, dart:ffi, etc.)

Details

Follow Dart file conventions (30/30)

✔ 10/10 points: Provide a valid pubspec.yaml

✔ 5/5 points: Provide a valid README.md

✔ 5/5 points: Provide a valid CHANGELOG.md

✔ 10/10 points: Use an OSI-approved license

Detected license: BSD-3-Clause.

Provide documentation (20/20)

✔ 10/10 points: 20% or more of the public API has dartdoc comments

690 out of 1118 API elements (61.7 %) have documentation comments.

Some symbols that are missing documentation: sentry_dart.utf8JsonEncoder, sentry_io, sentry_io.Breadcrumb.Breadcrumb.console, sentry_io.Breadcrumb.Breadcrumb.http, sentry_io.Breadcrumb.Breadcrumb.userInteraction.

✔ 10/10 points: Package has an example

Platform support (20/20)

✔ 20/20 points: Supports 6 of 6 possible platforms (iOS, Android, Web, Windows, macOS, Linux)

  • ✓ Android

  • ✓ iOS

  • ✓ Windows

  • ✓ Linux

  • ✓ macOS

  • ✓ Web

❌ 0/0 points: WASM compatibility

Package not compatible with runtime wasm

Because:

  • package:sentry/sentry.dart that imports:
  • package:sentry/src/type_check_hint.dart that imports:
  • package:sentry/src/http_client/failed_request_client.dart that imports:
  • package:sentry/src/http_client/sentry_http_client.dart that imports:
  • package:sentry/src/http_client/breadcrumb_client.dart that imports:
  • package:sentry/src/hub_adapter.dart that imports:
  • package:sentry/src/sentry.dart that imports:
  • package:sentry/src/dart_exception_type_identifier.dart that imports:
  • package:sentry/src/dart_exception_type_identifier_io.dart that imports:
  • dart:io

This package is not compatible with runtime wasm, and will not be rewarded full points in a future version of the scoring model.

See https://dart.dev/web/wasm for details.

Pass static analysis (50/50)

✔ 50/50 points: code has no errors, warnings, lints, or formatting issues

Support up-to-date dependencies (20/40)

✔ 10/10 points: All of the package dependencies are supported in the latest version

Package Constraint Compatible Latest
http >=0.13.0 <2.0.0 1.2.2 1.2.2
meta ^1.3.0 1.15.0 1.15.0
stack_trace ^1.10.0 1.11.1 1.11.1
uuid >=3.0.0 <5.0.0 4.5.0 4.5.0
Transitive dependencies
Package Constraint Compatible Latest
async - 2.11.0 2.11.0
collection - 1.19.0 1.19.0
crypto - 3.0.5 3.0.5
fixnum - 1.1.0 1.1.0
http_parser - 4.1.0 4.1.0
path - 1.9.0 1.9.0
source_span - 1.10.0 1.10.0
sprintf - 7.0.0 7.0.0
string_scanner - 1.3.0 1.3.0
term_glyph - 1.2.1 1.2.1
typed_data - 1.3.2 1.3.2
web - 1.0.0 1.0.0

To reproduce run dart pub outdated --no-dev-dependencies --up-to-date --no-dependency-overrides.

✔ 10/10 points: Package supports latest stable Dart and Flutter SDKs

❌ 0/20 points: Compatible with dependency constraint lower bounds

downgrade analysis failed failed with 4 errors:

  • URI_DOES_NOT_EXIST - lib/src/event_processor/enricher/web_enricher_event_processor.dart:3:8 - Target of URI doesn't exist: 'package:web/web.dart'.
  • URI_DOES_NOT_EXIST - lib/src/origin_web.dart:3:8 - Target of URI doesn't exist: 'package:web/web.dart'.
  • UNDEFINED_IDENTIFIER - lib/src/origin_web.dart:6:30 - Undefined name 'window'.

Run dart pub downgrade and then dart analyze to reproduce the above problem.

You may run dart pub upgrade --tighten to update your dependency constraints, see dart.dev/go/downgrade-testing for details.

Versions