Symbolicate Dart stacktrace on Flutter Android and iOS without debug images from native sdks #2256

buenaflor · 2024-08-28T18:30:29Z

📜 Description

Dart StackTraces can be symbolicated with Sentry.init on Flutter iOS, macOS and Android

Uses the stacktrace header, specifically isolateDsoBase / vmDsoBase & build_id to construct a synthetic debug image which allows symbolication to work also on dart stacktraces without debug images that we get from the cocoa and android sdks.

💡 Motivation and Context

There's a need for using only sentry-dart on Flutter due to app size limitations, this should allow for some symbolication.

💚 How did you test it?

Unit test, local testing

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
I updated the docs if needed
All tests passing
No breaking changes

🔮 Next steps

Get the code_file path somehow, is probably not possible with a pure dart setup

github-actions · 2024-08-28T18:31:14Z

	Fails
🚫	Please consider adding a changelog entry for the next release.

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Symbolicate Dart stacktrace on Flutter Android and iOS without debug images from native sdks ([#2256](https://github.com/getsentry/sentry-dart/pull/2256))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 6a5a555

codecov · 2024-08-28T18:31:37Z

Codecov Report

Attention: Patch coverage is 94.11765% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.23%. Comparing base (77db8d4) to head (6a5a555).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
dart/lib/src/debug_image_extractor.dart	93.33%	5 Missing ⚠️
...rt/lib/src/load_dart_debug_images_integration.dart	95.65%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2256      +/-   ##
==========================================
+ Coverage   88.14%   88.23%   +0.09%     
==========================================
  Files         245      247       +2     
  Lines        8442     8533      +91     
==========================================
+ Hits         7441     7529      +88     
- Misses       1001     1004       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-08-28T19:34:06Z

Android Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	460.69 ms	513.40 ms	52.71 ms
Size	6.49 MiB	7.55 MiB	1.06 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`a094100`	388.02 ms	459.50 ms	71.48 ms
`4829ad3`	381.55 ms	455.45 ms	73.90 ms
`8a7f528`	290.27 ms	341.80 ms	51.53 ms
`5f443de`	412.30 ms	491.67 ms	79.37 ms
`fdac48a`	329.50 ms	396.46 ms	66.96 ms
`90db9ff`	334.86 ms	388.14 ms	53.28 ms
`559d28f`	302.35 ms	339.53 ms	37.18 ms
`48adddf`	353.96 ms	431.10 ms	77.14 ms
`afa6e2a`	349.73 ms	428.48 ms	78.75 ms
`cc80714`	333.26 ms	388.80 ms	55.54 ms

App size

Revision	Plain	With Sentry	Diff
`a094100`	5.94 MiB	6.96 MiB	1.02 MiB
`4829ad3`	6.33 MiB	7.26 MiB	943.11 KiB
`8a7f528`	6.06 MiB	7.03 MiB	989.36 KiB
`5f443de`	6.35 MiB	7.34 MiB	1008.00 KiB
`fdac48a`	6.06 MiB	7.09 MiB	1.03 MiB
`90db9ff`	6.06 MiB	7.10 MiB	1.04 MiB
`559d28f`	5.94 MiB	6.92 MiB	1001.70 KiB
`48adddf`	6.27 MiB	7.20 MiB	959.09 KiB
`afa6e2a`	6.27 MiB	7.20 MiB	955.69 KiB
`cc80714`	6.34 MiB	7.28 MiB	966.31 KiB

Previous results on branch: feat/dart-symbolication

Startup times

Revision	Plain	With Sentry	Diff
`45b2e65`	481.24 ms	507.70 ms	26.46 ms
`558a9dc`	414.90 ms	461.30 ms	46.41 ms
`d592ffd`	455.08 ms	500.12 ms	45.04 ms
`72c2844`	432.29 ms	497.96 ms	65.67 ms
`a6ffe97`	417.47 ms	439.63 ms	22.16 ms
`28e031c`	421.32 ms	482.64 ms	61.32 ms
`f7d358e`	411.28 ms	481.19 ms	69.91 ms
`cd8b486`	466.46 ms	547.16 ms	80.70 ms
`465b643`	432.32 ms	496.63 ms	64.31 ms
`621a095`	470.26 ms	501.73 ms	31.47 ms

App size

Revision	Plain	With Sentry	Diff
`45b2e65`	6.49 MiB	7.55 MiB	1.06 MiB
`558a9dc`	6.52 MiB	7.59 MiB	1.07 MiB
`d592ffd`	6.52 MiB	7.59 MiB	1.07 MiB
`72c2844`	6.52 MiB	7.59 MiB	1.07 MiB
`a6ffe97`	6.52 MiB	7.59 MiB	1.07 MiB
`28e031c`	6.52 MiB	7.59 MiB	1.07 MiB
`f7d358e`	6.52 MiB	7.59 MiB	1.07 MiB
`cd8b486`	6.52 MiB	7.59 MiB	1.07 MiB
`465b643`	6.52 MiB	7.61 MiB	1.09 MiB
`621a095`	6.52 MiB	7.59 MiB	1.07 MiB

github-actions · 2024-08-28T19:39:29Z

iOS Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1254.61 ms	1278.81 ms	24.20 ms
Size	8.38 MiB	9.73 MiB	1.35 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`a5031f1`	1244.14 ms	1268.79 ms	24.64 ms
`1a93825`	1257.25 ms	1261.55 ms	4.30 ms
`c70e01a`	1273.00 ms	1299.12 ms	26.12 ms
`e8603bb`	1240.85 ms	1254.79 ms	13.94 ms
`c978477`	1228.43 ms	1249.17 ms	20.74 ms
`c328ffc`	1236.73 ms	1260.73 ms	24.00 ms
`bffc2c5`	1239.76 ms	1264.67 ms	24.92 ms
`89ea268`	1252.33 ms	1253.58 ms	1.26 ms
`6e083bb`	1244.33 ms	1264.60 ms	20.26 ms
`d0476e1`	1259.45 ms	1280.31 ms	20.86 ms

App size

Revision	Plain	With Sentry	Diff
`a5031f1`	8.32 MiB	9.50 MiB	1.18 MiB
`1a93825`	8.28 MiB	9.34 MiB	1.05 MiB
`c70e01a`	8.16 MiB	9.17 MiB	1.01 MiB
`e8603bb`	8.33 MiB	9.40 MiB	1.07 MiB
`c978477`	8.32 MiB	9.50 MiB	1.18 MiB
`c328ffc`	8.34 MiB	9.67 MiB	1.33 MiB
`bffc2c5`	8.33 MiB	9.40 MiB	1.07 MiB
`89ea268`	8.09 MiB	9.16 MiB	1.06 MiB
`6e083bb`	8.16 MiB	9.17 MiB	1.01 MiB
`d0476e1`	8.33 MiB	9.64 MiB	1.31 MiB

Previous results on branch: feat/dart-symbolication

Startup times

Revision	Plain	With Sentry	Diff
`558a9dc`	1245.87 ms	1262.65 ms	16.78 ms
`a6ffe97`	1221.69 ms	1243.37 ms	21.67 ms
`72c2844`	1239.30 ms	1258.73 ms	19.44 ms
`28e031c`	1266.10 ms	1277.54 ms	11.44 ms
`465b643`	1237.22 ms	1250.79 ms	13.57 ms
`d592ffd`	1248.78 ms	1267.13 ms	18.35 ms
`45b2e65`	1265.86 ms	1279.75 ms	13.89 ms
`cd8b486`	1242.14 ms	1255.43 ms	13.29 ms
`621a095`	1235.51 ms	1255.47 ms	19.96 ms
`f7d358e`	1244.02 ms	1262.43 ms	18.41 ms

App size

Revision	Plain	With Sentry	Diff
`558a9dc`	8.38 MiB	9.72 MiB	1.34 MiB
`a6ffe97`	8.38 MiB	9.72 MiB	1.34 MiB
`72c2844`	8.38 MiB	9.72 MiB	1.34 MiB
`28e031c`	8.38 MiB	9.72 MiB	1.34 MiB
`465b643`	8.38 MiB	9.73 MiB	1.36 MiB
`d592ffd`	8.38 MiB	9.72 MiB	1.34 MiB
`45b2e65`	8.38 MiB	9.73 MiB	1.35 MiB
`cd8b486`	8.38 MiB	9.72 MiB	1.34 MiB
`621a095`	8.38 MiB	9.72 MiB	1.34 MiB
`f7d358e`	8.38 MiB	9.72 MiB	1.34 MiB

dart/lib/src/debug_image_extractor.dart

stefanosiano

looks good overall!
just a question on an integration name

flutter/lib/src/integrations/load_native_debug_images_integration.dart

…rmat parsing

CHANGELOG.md

…tsentry/sentry-dart into fix/flutter-multiview-support * 'fix/flutter-multiview-support' of https://github.com/getsentry/sentry-dart: Update CHANGELOG.md release: 8.9.0 chore: rename errorSampleRate to onErrorSampleRate (#2270) fix: repost replay screenshots on android while idle (#2275) feat: capture touch breadcrumbs for all buttons (#2242) Symbolicate Dart stacktrace on Flutter Android and iOS without debug images from native sdks (#2256) Fix: Support allowUrls, denyUrls (#2271) chore(deps): update Flutter SDK (metrics) to v3.24.2 (#2272)

* chore(deps): update Cocoa SDK to v8.30.1 (getsentry#2155) * chore: update flutter/scripts/update-cocoa.sh to 8.30.1 * formatting --------- Co-authored-by: GitHub <[email protected]> Co-authored-by: GIancarlo Buenaflor <[email protected]> * Set dart runtime version with parsed `Platform.version` (getsentry#2156) * Parse semver * Move dart version to late and only extract it once during init * Set dartVersion to private and move _extractDartVersion out of init * Record dropped spans in client reports (getsentry#2154) * Record dropped spans * Changelog * Naming * Update CHANGELOG.md * Send dropped event as well for rate limit and network error * Update * Dart analyze * Fix test * Improve comments * improvements * Apply same logic of beforeSend to event processor * Fix test * Formatting * Comments * Rename mock * Fix compatibility with Drift 2.19.0 (getsentry#2162) * Add support for drift 2.19.0 * Update * fix test * Update CHANGELOG * Add ignores * Fix flaky app start tests (getsentry#2157) * chore(deps): update Symbol collector CLI to v1.19.0 (getsentry#2164) Co-authored-by: GitHub <[email protected]> * Deprecate `setExtra` (getsentry#2159) * deprecate * update * Update deprecate message * Update CHANGELOG * Formatting and ignore warnings * analyze * deps: update ktlint (getsentry#2166) the new version should automatically resolve outdated comments * ci: validate publish dry runs (getsentry#2161) * draft script for checking publish * draft implementation * comment * trigger ci * Update workflow * Update workflow * Update workflow * Update workflow * revert example{ * Update workflow * Temporarily restrict drift for testing * Update pubspec.yaml * Update pubspec.yaml * Revert * Update analyze.yml * Update event_example.dart * Add flag to disable reporting of view hierarchy identifiers (getsentry#2158) * Add report view hierarchy identifier option * Update docs * Update CHANGELOG * Fix test * Formatting * Update CHANGELOG.md * release: 8.4.0 * Update CHANGELOG * build(deps): bump reactivecircus/android-emulator-runner (getsentry#2171) Bumps [reactivecircus/android-emulator-runner](https://github.com/reactivecircus/android-emulator-runner) from 2.31.0 to 2.32.0. - [Release notes](https://github.com/reactivecircus/android-emulator-runner/releases) - [Changelog](https://github.com/ReactiveCircus/android-emulator-runner/blob/main/CHANGELOG.md) - [Commits](ReactiveCircus/android-emulator-runner@77986be...f0d1ed2) --- updated-dependencies: - dependency-name: reactivecircus/android-emulator-runner dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): update Cocoa SDK to v8.31.1 (getsentry#2174) * chore: update flutter/scripts/update-cocoa.sh to 8.31.1 * format generated binding --------- Co-authored-by: GitHub <[email protected]> Co-authored-by: Ivan Dlugos <[email protected]> * chore(deps): update Android SDK to v7.12.0 (getsentry#2173) * chore: update flutter/scripts/update-android.sh to 7.12.0 * chore: update AGP and Kotlin --------- Co-authored-by: GitHub <[email protected]> Co-authored-by: Ivan Dlugos <[email protected]> Co-authored-by: Giancarlo Buenaflor <[email protected]> * Fix truncated stacktraces in unhandled errors (getsentry#2152) * Fix stacktrace * Fix stacktrace * Update * Update changelog * Add test cases * formatting * formatting * Fix await * build(deps): bump ruby/setup-ruby from 1.185.0 to 1.187.0 (getsentry#2172) Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.185.0 to 1.187.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@3a77c29...161cd54) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Giancarlo Buenaflor <[email protected]> * fix analyze issues (getsentry#2177) * Update CHANGELOG.md (getsentry#2178) * Disable sff & frame delay detection on web, linux and windows (getsentry#2182) * disable * chore: update metrics/flutter.properties to 3.22.3 (getsentry#2180) Co-authored-by: GitHub <[email protected]> * build(deps): bump gradle/gradle-build-action from 3.4.2 to 3.5.0 (getsentry#2186) Bumps [gradle/gradle-build-action](https://github.com/gradle/gradle-build-action) from 3.4.2 to 3.5.0. - [Release notes](https://github.com/gradle/gradle-build-action/releases) - [Commits](gradle/gradle-build-action@66535aa...ac2d340) --- updated-dependencies: - dependency-name: gradle/gradle-build-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump ruby/setup-ruby from 1.187.0 to 1.188.0 (getsentry#2187) Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.187.0 to 1.188.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@161cd54...50ba338) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Support `ignoredExceptionsForType` (getsentry#2150) * Set platform in sentry frames for better raw stacktrace representation (getsentry#2193) * add platform to stacktrace * update * Update CHANGELOG * Fix tests * Fix test * release: 8.5.0 * chore(deps): update Cocoa SDK to v8.32.0 (getsentry#2195) * chore: update flutter/scripts/update-cocoa.sh to 8.32.0 * Format --------- Co-authored-by: GitHub <[email protected]> Co-authored-by: GIancarlo Buenaflor <[email protected]> * chore(deps): update Symbol collector CLI to v1.21.0 (getsentry#2196) Co-authored-by: GitHub <[email protected]> * Implement error type identifier to mitigate obfuscated Flutter issue titles (getsentry#2170) * try to mitigate runtime type not being obfuscated * fix imports * Remove prints * Update * Update * Update exception_type_identifier.dart * Add caching * Update * split up dart:io and dart:html exceptions * fix analyze * Update CHANGELOG * update * Add more tests * Update docs * Update options docs * remove print * remove CustomException * import with show * try fix test * Update CHANGELOG.md * Update CHANGELOG.md * Fix analyze * try fix test * Update CHANGELOG.md * chore: update flutter/scripts/update-android.sh to 7.12.1 (getsentry#2198) Co-authored-by: GitHub <[email protected]> * Deprecate `enableTracing` (getsentry#2199) * Deprecate * Add CHANGELOG * Fix flaky exception identifier test on web (getsentry#2201) * Fix test * build(deps): bump ruby/setup-ruby from 1.188.0 to 1.190.0 (getsentry#2202) Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.188.0 to 1.190.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@50ba338...a6e6f86) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * release: 8.6.0 * chore: update flutter/scripts/update-android.sh to 7.13.0 (getsentry#2206) Co-authored-by: GitHub <[email protected]> * Add `ignored` discard reason (getsentry#2204) * deps: change updater PR strategy to update on low-risk updates (getsentry#2210) Flutter SDK in metrics and symbol-collector update jobs aren't expected to break so there's little reason to keep old PRs * feat: add span level measurements getsentry#1855 (getsentry#2214) * feat: add span level measurements * add changelog entry * add issue link to changelog * fix: correct changelog * moved the stored measurements from root span to tracer * changed issue number to pr number in changelog * fixed formatting * Update CHANGELOG.md Co-authored-by: Giancarlo Buenaflor <[email protected]> --------- Co-authored-by: Martin <[email protected]> Co-authored-by: Giancarlo Buenaflor <[email protected]> * feat: add `ignoreTransactions` and ignoreErrors` getsentry#1391 (getsentry#2207) * Add ignoreTransactions and ignoreErrors getsentry#1391 * chore: add changelog entry * move methods from sentry_options to sentry_client and change to private * change discard reason to ignored Co-authored-by: Giancarlo Buenaflor <[email protected]> * change iterable to list * add event recorder to ignoredTransactions * add tests for ignoreTransactions * set ignoreErrors list to empty list a default Co-authored-by: Giancarlo Buenaflor <[email protected]> * change variables to final for ignoreTransaction Co-authored-by: Giancarlo Buenaflor <[email protected]> * change var to final for ignoreErrors and adapt test * Update CHANGELOG.md Co-authored-by: Giancarlo Buenaflor <[email protected]> * Add example for ignoreTransactions and ignoreErrors to changelog * fix: check for empty ignoreError and ignoreTransaction before handling regex * moved ignoreTransactions and ignoreErrors back to unreleased area in CHANGELOG.md * refactored implementation of ignoreErrors and ignoreTransactions and improved test cases * removed unnecessary backslash from tests --------- Co-authored-by: Martin <> Co-authored-by: Martin <[email protected]> Co-authored-by: Giancarlo Buenaflor <[email protected]> * Deserialize and serialize unknown fields (getsentry#2153) * Add proxy support (getsentry#2192) * chore(deps): update Cocoa SDK to v8.33.0 (getsentry#2223) * chore: update flutter/scripts/update-cocoa.sh to 8.33.0 * Formatting * fix analyze --------- Co-authored-by: GitHub <[email protected]> Co-authored-by: GIancarlo Buenaflor <[email protected]> * release: 8.7.0 * add ignoreRoutes parameter to SentryNavigatorObserver (getsentry#2218) * add ignoreRoutes parameter to SentryNavigatorObserver * add unitTest for ignoreRoutes * add changelog entry for ignoreRoutes in the SentryNaviagtorObserver * add for ignore routes, that not TTID and TTFD spans are created Co-authored-by: Giancarlo Buenaflor <[email protected]> * add further tests for ignore routes * fix changelog and move ignoreRoutes to unreleased --------- Co-authored-by: Giancarlo Buenaflor <[email protected]> * chore(deps): update Flutter SDK (metrics) to v3.24.0 (getsentry#2229) Co-authored-by: GitHub <[email protected]> * chore(deps): update Android SDK to v7.14.0 (getsentry#2228) Co-authored-by: GitHub <[email protected]> * test: flutter wasm (getsentry#2231) * test: flutter wasm * temporarily disable failing tests * fixup ci * cleanup * feat: Debouncing of SentryWidgetsBindingObserver.didChangeMetrics. getsentry#400 (getsentry#2232) * feat: add debouncer for SentryWidgetsBindingObserver.didChangeMetrics * adapt tests for debouncing * add changelog entry for debouncer * Update flutter/lib/src/utils/debouncer.dart Co-authored-by: Giancarlo Buenaflor <[email protected]> * Update flutter/test/widgets_binding_observer_test.dart Co-authored-by: Giancarlo Buenaflor <[email protected]> * add internal to debouncer and add whitespaces to comments --------- Co-authored-by: Giancarlo Buenaflor <[email protected]> * Provide a way to cause an example native crash from Flutter (getsentry#2239) * add SentryFlutter.nativeCrash() for Android and iOS * add changelog entry * remove unused variable * improved kotlin implementation * fix kotlin analysis warnings * Update CHANGELOG.md Co-authored-by: Giancarlo Buenaflor <[email protected]> * fix kotlin linter errors * remove whitespace * add Description for nativeCrash --------- Co-authored-by: Giancarlo Buenaflor <[email protected]> * chore(deps): update Cocoa SDK to v8.35.1 (getsentry#2247) * chore: update flutter/scripts/update-cocoa.sh to 8.35.1 * format --------- Co-authored-by: GitHub <[email protected]> Co-authored-by: GIancarlo Buenaflor <[email protected]> * chore: fix cocoa bump changelog (getsentry#2248) * release: 8.8.0 * chore(deps): update Flutter SDK (metrics) to v3.24.1 (getsentry#2245) Co-authored-by: GitHub <[email protected]> * chore(deps): update Cocoa SDK to v8.36.0 (getsentry#2252) * chore: update flutter/scripts/update-cocoa.sh to 8.36.0 * update --------- Co-authored-by: GitHub <[email protected]> Co-authored-by: GIancarlo Buenaflor <[email protected]> * chore: update windows code based on latest flutter template with plugin_ffi (getsentry#2243) * allow internet and network state access in the flutter example app (getsentry#2255) * allow internet and network state access in the example app * add changelog * feat: Replay support for mobile (getsentry#2208) * Flutter replay for Android (getsentry#2032) * minor gradle fixes * tmp: local sentry-java build * tmp: use relative path to sentry-java * tmp: local java build patches * replay options * replay recorder * wip: JNI native bindings * use compatible jnigen * add missing gradlew to flutter/android * replay recorder JNI binding code * replay recorder binding jni code * jni 0.6 * wip: android jni replay * replay binding * glue code for jni * chore: update to cocoa 8.24.1-alpha.0 * wip: cocoa integration * wip: ios replay * cleanup * formatting * android fixes * move native setup to the native sdk integration * cleanup & improvements * improve widget filter and implement redact options * fix image scaling * ktlint format * ci fixes * fix tests * add jnigen scripts * use android 7.9.0 alpha.1 * move native init & close to SentryNative * cleanup * add macOS integration link * rollback cocoa changes * remove jni/jnigen * wip: methodchannel based android recorder * callback * linter issues * minor fixes * more fixes * linter issues * cleanup * improve logging * move replay to experimental, same as in other SDKs * improve tree shaking * test: scheduler * support browser test * fix compat with old flutter * cleanup * rename recorder_widget_filter.dart * fixup scheduler test * improve test coverage * pr cleanup * test: widget filter * cleanup * test widget filter visibility * cleanup * always add screenshot widget * recorder test * cleanup * limit recorder test to vm * wip: integration test * cleanup * ktlint format * detekt suppression * ktlint format * improve scheduler stop behavior * wip: error replay mapping * suppress detekt TooGenericExceptionThrown * Update flutter/lib/src/replay/recorder.dart Co-authored-by: Giancarlo Buenaflor <[email protected]> * Update flutter/lib/src/native/java/sentry_native_java.dart Co-authored-by: Giancarlo Buenaflor <[email protected]> * improve comments * feat: associate dart errors with replays (getsentry#2070) * feat: associate dart errors with replays * ktlint * cleanup * tests * chote: remove path dependency * fix tests * feat: replay breadcrumbs (android) (getsentry#2163) * feat: replay breadcrumbs * ktlint format * fixup tests * cleanup * linter issues * detekt linter issue * move touch path build to dart to deduplicate * fix metrics app compilation * linter issue * test: native replay integration binding (getsentry#2189) * wip: test native integration * test: native replay binding * update example * chore: update pubspec * fixup tests * Update flutter/test/mocks.dart * chore: update changelog * fix publishing * release: 8.6.0-alpha.2 --------- Co-authored-by: Giancarlo Buenaflor <[email protected]> Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]> * fix: update android calls after SDK update (getsentry#2211) * fix: update android calls after SDK update * ktlint * feat: iOS replay support (getsentry#2209) * minor gradle fixes * tmp: local sentry-java build * tmp: use relative path to sentry-java * tmp: local java build patches * replay options * replay recorder * wip: JNI native bindings * use compatible jnigen * add missing gradlew to flutter/android * replay recorder JNI binding code * replay recorder binding jni code * jni 0.6 * wip: android jni replay * replay binding * glue code for jni * chore: update to cocoa 8.24.1-alpha.0 * wip: cocoa integration * wip: ios replay * cleanup * formatting * android fixes * move native setup to the native sdk integration * cleanup & improvements * improve widget filter and implement redact options * fix image scaling * ktlint format * ci fixes * fix tests * add jnigen scripts * use android 7.9.0 alpha.1 * move native init & close to SentryNative * cleanup * add macOS integration link * rollback cocoa changes * remove jni/jnigen * wip: methodchannel based android recorder * callback * linter issues * minor fixes * more fixes * linter issues * cleanup * improve logging * move replay to experimental, same as in other SDKs * improve tree shaking * test: scheduler * support browser test * fix compat with old flutter * cleanup * rename recorder_widget_filter.dart * fixup scheduler test * improve test coverage * pr cleanup * test: widget filter * cleanup * test widget filter visibility * cleanup * always add screenshot widget * recorder test * cleanup * limit recorder test to vm * wip: integration test * cleanup * ktlint format * detekt suppression * ktlint format * improve scheduler stop behavior * wip: error replay mapping * suppress detekt TooGenericExceptionThrown * Update flutter/lib/src/replay/recorder.dart Co-authored-by: Giancarlo Buenaflor <[email protected]> * Update flutter/lib/src/native/java/sentry_native_java.dart Co-authored-by: Giancarlo Buenaflor <[email protected]> * improve comments * feat: associate dart errors with replays (getsentry#2070) * feat: associate dart errors with replays * ktlint * cleanup * tests * chote: remove path dependency * wip: ios replay * fix result callback * iOS related refactorings * logs * fix tests * call captureReplay on iOS & set * ios replay breadcrumbs * feat: replay breadcrumbs (android) (getsentry#2163) * feat: replay breadcrumbs * ktlint format * fixup tests * cleanup * linter issues * detekt linter issue * move touch path build to dart to deduplicate * fix metrics app compilation * linter issue * test: native replay integration binding (getsentry#2189) * wip: test native integration * test: native replay binding * update example * chore: update pubspec * fixup tests * Update flutter/test/mocks.dart * chore: update changelog * fix publishing * release: 8.6.0-alpha.2 * cleanup * fix macos compilation * test: iOS support * linter issues * linter issues * chore: update changelog * Update flutter/lib/src/native/cocoa/sentry_native_cocoa.dart Co-authored-by: Giancarlo Buenaflor <[email protected]> --------- Co-authored-by: Giancarlo Buenaflor <[email protected]> Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]> * fix: cocoa sdk renamed errorSampleRate to onErrorSampleRate * fixup changelog * release: 8.8.0-alpha.1 * chore: update changelog * update changelog --------- Co-authored-by: Giancarlo Buenaflor <[email protected]> Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]> * chore: fixup changelog (getsentry#2260) * refactor: Remove workaround for Spotlight image handling (getsentry#2253) * fix: capture replay call on iOS (getsentry#2264) * Support allowUrls, denyUrls (getsentry#2227) * moved regex matcher into regex utils * add allowUrls, denyUrls for web * add changelog entry for allowUrls and denyUrls * add conditional import for non web platforms * fix multiplatform build * fix wording in sentry options * Update dart/lib/src/utils/regex_utils.dart Co-authored-by: Giancarlo Buenaflor <[email protected]> * Update dart/lib/src/sentry_options.dart Co-authored-by: Giancarlo Buenaflor <[email protected]> * Update dart/lib/src/sentry_options.dart Co-authored-by: Giancarlo Buenaflor <[email protected]> * add tests for isMatchingRegexPattern * simplified allowUrls and denyUrls handling * moved allowUrls and denyUrls from dart to flutter * add event processor for html * rephrased documentation and split up tests for web and mobile platform. * add expected error * Update scripts/publish_validation/bin/publish_validation.dart Co-authored-by: Giancarlo Buenaflor <[email protected]> * Update flutter/lib/src/event_processor/url_filter/html_url_filter_event_processor.dart Co-authored-by: Giancarlo Buenaflor <[email protected]> * Update flutter/lib/src/event_processor/url_filter/web_url_filter_event_processor.dart Co-authored-by: Giancarlo Buenaflor <[email protected]> --------- Co-authored-by: Giancarlo Buenaflor <[email protected]> * Only access renderObject if `hasSize` is true (getsentry#2263) * feat: asset images don't need to be obscured in replay (getsentry#2269) * feat: asset images don't need to be obscured * chore: update changelog * feat: improve obscure rectangle fit/size (getsentry#2236) * chore(deps): update Flutter SDK (metrics) to v3.24.2 (getsentry#2272) Co-authored-by: GitHub <[email protected]> * Fix: Support allowUrls, denyUrls (getsentry#2271) * moved regex matcher into regex utils * add allowUrls, denyUrls for web * add changelog entry for allowUrls and denyUrls * add conditional import for non web platforms * fix multiplatform build * fix wording in sentry options * Update dart/lib/src/utils/regex_utils.dart Co-authored-by: Giancarlo Buenaflor <[email protected]> * Update dart/lib/src/sentry_options.dart Co-authored-by: Giancarlo Buenaflor <[email protected]> * Update dart/lib/src/sentry_options.dart Co-authored-by: Giancarlo Buenaflor <[email protected]> * add tests for isMatchingRegexPattern * simplified allowUrls and denyUrls handling * moved allowUrls and denyUrls from dart to flutter * add event processor for html * rephrased documentation and split up tests for web and mobile platform. * add expected error * Update scripts/publish_validation/bin/publish_validation.dart Co-authored-by: Giancarlo Buenaflor <[email protected]> * Update flutter/lib/src/event_processor/url_filter/html_url_filter_event_processor.dart Co-authored-by: Giancarlo Buenaflor <[email protected]> * Update flutter/lib/src/event_processor/url_filter/web_url_filter_event_processor.dart Co-authored-by: Giancarlo Buenaflor <[email protected]> * modified code to go through stacktrace frames * change matching to window.location --------- Co-authored-by: Giancarlo Buenaflor <[email protected]> * Symbolicate Dart stacktrace on Flutter Android and iOS without debug images from native sdks (getsentry#2256) * add symbolication * update implementation * update * update * update * update * update * update comment * update * update * update * fix * update * fix tests * fix initial value test * Update comment and test * update * Update NeedsSymbolication * revert sample * revert * update * update naming * update naming and comments of flag * set stacktrace in hint * update * add changelog * update * fix test * fix test * cache debug image * updaet * update var name * updaet * update naming * improve names * break early safeguard for parsing stacktrace and dont throw in hex format parsing * revert load native image list integration * update * fix analyze * fix analyze * feat: capture touch breadcrumbs for all buttons (getsentry#2242) * chore: cleanup user interaction widget code * renames & more cleanup * more cleanup * more refactoring & clenaup before actual functional changes * more refactoring * feat: collect touch element path * update tests * add tests for the new support of non-keyed button presses * cleanup & improve existing code * chore: update changelog * update native replay integration with touch breadcrumb path * fix tests * Update CHANGELOG.md * linter issues --------- Co-authored-by: Giancarlo Buenaflor <[email protected]> * fix: repost replay screenshots on android while idle (getsentry#2275) * fix: repost replay screenshots on android while idle * chore: changelog * review change * chore: rename errorSampleRate to onErrorSampleRate (getsentry#2270) * chore: rename errorSampleRate to onErrorSampleRate * Update CHANGELOG.md * release: 8.9.0 * Update CHANGELOG.md * build(deps): bump natiginfo/action-detekt-all from 1.23.6 to 1.23.7 (getsentry#2278) Bumps [natiginfo/action-detekt-all](https://github.com/natiginfo/action-detekt-all) from 1.23.6 to 1.23.7. - [Release notes](https://github.com/natiginfo/action-detekt-all/releases) - [Commits](natiginfo/action-detekt-all@b9daaf5...6bf4342) --- updated-dependencies: - dependency-name: natiginfo/action-detekt-all dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump ruby/setup-ruby from 1.190.0 to 1.191.0 (getsentry#2279) Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.190.0 to 1.191.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@a6e6f86...52753b7) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Giancarlo Buenaflor <[email protected]> * Fix typo (getsentry#2283) Fixes a small typo I stumbled upon when reading through the changelogs. #skip-changelog * chore(deps): update Flutter SDK (metrics) to v3.24.3 (getsentry#2287) Co-authored-by: GitHub <[email protected]> * fix: event processor failed to stop processing (getsentry#2289) * test: rethrow exceptions (getsentry#2290) * test: rethrow in native SDK integration * test: rethrow in automated test mode * fix event processor runner * test: use options.automatedTestMode everywhere * update failing tests * fix tests * formatting * fix tests * fix: tests * fix tests * update comments * Improve app start integration (getsentry#2266) * build(deps): bump ruby/setup-ruby from 1.191.0 to 1.192.0 (getsentry#2292) Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.191.0 to 1.192.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@52753b7...a6b46b8) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update CODEOWNERS (getsentry#2300) * block app start if appLaunchedInForeground is not set. (getsentry#2291) * block app start if appLaunchedInForeground is not set. * add changelog entry * call public method * fix deprecated toUpperCase to uppercase * Update flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt Co-authored-by: Giancarlo Buenaflor <[email protected]> * add 60 second timeout for app starts for android native * fix missing time imports * rearrange line * add comma --------- Co-authored-by: Giancarlo Buenaflor <[email protected]> * add missing file * rename deprecated method to avoid conflict if the method still available * add deleted file * merge with main * rename deprecated method to avoid conflict if the method still available * adde missing import --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub <[email protected]> Co-authored-by: GIancarlo Buenaflor <[email protected]> Co-authored-by: Ivan Dlugos <[email protected]> Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ivan Dlugos <[email protected]> Co-authored-by: Denis Andrašec <[email protected]> Co-authored-by: Martin Haintz <[email protected]> Co-authored-by: Martin <[email protected]> Co-authored-by: Giancarlo Buenaflor <[email protected]> Co-authored-by: Markus Hintersteiner <[email protected]> Co-authored-by: Karl Heinz Struggl <[email protected]>

buenaflor added 7 commits August 28, 2024 19:14

add symbolication

034d78c

update implementation

db74ff3

update

e6c1650

update

05ce21e

update

1e3a44a

update

a1e8aa1

update

dc02362

buenaflor added 4 commits August 28, 2024 20:33

update comment

345d81b

update

a260686

update

4caf3ad

update

966def4

buenaflor mentioned this pull request Aug 28, 2024

Sentry-dart support (not sentry-flutter) getsentry/sentry-dart-plugin#256

Closed

fix

a6ffe97

buenaflor added 13 commits August 29, 2024 01:35

update

188b0ee

fix tests

ef8ab0a

fix initial value test

558a9dc

Update comment and test

666b65f

update

621a095

Update NeedsSymbolication

c3ec5e8

revert sample

df5d983

revert

859ac24

update

cd8b486

update naming

6369c35

update naming and comments of flag

f7d358e

set stacktrace in hint

db3bf92

update

07f0b6b

Merge branch 'main' into feat/dart-symbolication

28e031c

buenaflor changed the title ~~Symbolicate pure Dart stacktrace on Flutter Android and iOS~~ Symbolicate Dart stacktrace on Flutter Android and iOS without debug images from native sdks Aug 29, 2024

update

88cfa1f

buenaflor commented Aug 29, 2024

View reviewed changes

dart/lib/src/debug_image_extractor.dart Outdated Show resolved Hide resolved

buenaflor added 8 commits August 29, 2024 16:47

fix test

e10f9b7

fix test

72c2844

cache debug image

16ded43

updaet

09864a7

update var name

b50b2d8

updaet

30a12fd

update naming

05044c2

improve names

d592ffd

buenaflor marked this pull request as ready for review August 29, 2024 23:02

buenaflor requested review from krystofwoldrich and stefanosiano as code owners August 29, 2024 23:02

buenaflor requested a review from vaind September 2, 2024 11:38

stefanosiano reviewed Sep 4, 2024

View reviewed changes

flutter/lib/src/integrations/load_native_debug_images_integration.dart Outdated Show resolved Hide resolved

buenaflor added 4 commits September 4, 2024 14:08

break early safeguard for parsing stacktrace and dont throw in hex fo…

11ef042

…rmat parsing

revert load native image list integration

6dab4d8

update

22741a3

Merge branch 'main' into feat/dart-symbolication

465b643

stefanosiano approved these changes Sep 4, 2024

View reviewed changes

buenaflor added 3 commits September 9, 2024 11:16

Merge branch 'main' into feat/dart-symbolication

45b2e65

fix analyze

e1d019b

fix analyze

6a5a555

buenaflor merged commit d5696bf into main Sep 9, 2024
134 checks passed

buenaflor deleted the feat/dart-symbolication branch September 9, 2024 11:21

vaind reviewed Sep 9, 2024

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Symbolicate Dart stacktrace on Flutter Android and iOS without debug images from native sdks #2256

Symbolicate Dart stacktrace on Flutter Android and iOS without debug images from native sdks #2256

buenaflor commented Aug 28, 2024 •

edited

Loading

github-actions bot commented Aug 28, 2024 •

edited

Loading

codecov bot commented Aug 28, 2024 •

edited

Loading

github-actions bot commented Aug 28, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/dart-symbolication

Startup times

App size

github-actions bot commented Aug 28, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/dart-symbolication

Startup times

App size

stefanosiano left a comment

Symbolicate Dart stacktrace on Flutter Android and iOS without debug images from native sdks #2256

Symbolicate Dart stacktrace on Flutter Android and iOS without debug images from native sdks #2256

Conversation

buenaflor commented Aug 28, 2024 • edited Loading

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Aug 28, 2024 • edited Loading

Instructions and example for changelog

codecov bot commented Aug 28, 2024 • edited Loading

Codecov Report

github-actions bot commented Aug 28, 2024 • edited Loading

Android Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/dart-symbolication

Startup times

App size

github-actions bot commented Aug 28, 2024 • edited Loading

iOS Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/dart-symbolication

Startup times

App size

stefanosiano left a comment

Choose a reason for hiding this comment

buenaflor commented Aug 28, 2024 •

edited

Loading

github-actions bot commented Aug 28, 2024 •

edited

Loading

codecov bot commented Aug 28, 2024 •

edited

Loading

github-actions bot commented Aug 28, 2024 •

edited

Loading

github-actions bot commented Aug 28, 2024 •

edited

Loading