Fix: Support allowUrls, denyUrls #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Giancarlo Buenaflor <[email protected]>
Co-authored-by: Giancarlo Buenaflor <[email protected]>
Co-authored-by: Giancarlo Buenaflor <[email protected]>
Co-authored-by: Giancarlo Buenaflor <[email protected]>
…nt_processor.dart Co-authored-by: Giancarlo Buenaflor <[email protected]>
…t_processor.dart Co-authored-by: Giancarlo Buenaflor <[email protected]>
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 202b83f | 357.79 ms | 419.47 ms | 61.68 ms |
| 6957bfd | 325.88 ms | 380.30 ms | 54.43 ms |
| d089990 | 361.67 ms | 442.50 ms | 80.83 ms |
| 519423f | 357.00 ms | 415.77 ms | 58.77 ms |
| 5aa047a | 329.45 ms | 403.18 ms | 73.73 ms |
| 40680d3 | 323.55 ms | 390.29 ms | 66.73 ms |
| 3a16179 | 471.61 ms | 513.45 ms | 41.83 ms |
| fcd1ee4 | 298.96 ms | 376.04 ms | 77.09 ms |
| 613760b | 373.42 ms | 399.33 ms | 25.92 ms |
| 0a23f98 | 377.19 ms | 416.18 ms | 39.00 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 202b83f | 6.34 MiB | 7.28 MiB | 966.66 KiB |
| 6957bfd | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| d089990 | 6.34 MiB | 7.28 MiB | 967.79 KiB |
| 519423f | 6.06 MiB | 7.03 MiB | 989.24 KiB |
| 5aa047a | 6.16 MiB | 7.14 MiB | 1011.25 KiB |
| 40680d3 | 6.06 MiB | 7.03 MiB | 989.25 KiB |
| 3a16179 | 6.52 MiB | 7.61 MiB | 1.08 MiB |
| fcd1ee4 | 6.16 MiB | 7.13 MiB | 1000.85 KiB |
| 613760b | 5.94 MiB | 6.92 MiB | 1005.98 KiB |
| 0a23f98 | 6.06 MiB | 7.03 MiB | 996.97 KiB |
Previous results on branch: feat/support-allow-urls-deny-urls
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 99a6f98 | 438.72 ms | 483.65 ms | 44.93 ms |
| 5598f4c | 422.39 ms | 466.30 ms | 43.91 ms |
| 1ec7235 | 487.81 ms | 582.18 ms | 94.37 ms |
| e5a3315 | 500.57 ms | 564.15 ms | 63.57 ms |
| 10639ce | 426.06 ms | 477.37 ms | 51.31 ms |
| a4c0d59 | 449.96 ms | 487.63 ms | 37.67 ms |
| 5e7ccc1 | 473.86 ms | 569.30 ms | 95.44 ms |
| 8523a6d | 415.31 ms | 464.65 ms | 49.33 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 99a6f98 | 6.52 MiB | 7.61 MiB | 1.08 MiB |
| 5598f4c | 6.52 MiB | 7.59 MiB | 1.06 MiB |
| 1ec7235 | 6.52 MiB | 7.59 MiB | 1.06 MiB |
| e5a3315 | 6.52 MiB | 7.61 MiB | 1.08 MiB |
| 10639ce | 6.52 MiB | 7.61 MiB | 1.08 MiB |
| a4c0d59 | 6.52 MiB | 7.59 MiB | 1.06 MiB |
| 5e7ccc1 | 6.52 MiB | 7.59 MiB | 1.06 MiB |
| 8523a6d | 6.52 MiB | 7.59 MiB | 1.06 MiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f056db1 | 1254.16 ms | 1268.38 ms | 14.22 ms |
| 6d317ea | 1277.27 ms | 1287.47 ms | 10.20 ms |
| ebfead1 | 1271.57 ms | 1284.48 ms | 12.91 ms |
| 8609bd8 | 1267.16 ms | 1291.39 ms | 24.22 ms |
| 33d0587 | 1262.16 ms | 1270.50 ms | 8.34 ms |
| 5112c69 | 1272.76 ms | 1293.37 ms | 20.61 ms |
| eb1a7c1 | 1281.25 ms | 1295.40 ms | 14.15 ms |
| 98d9a4a | 1244.73 ms | 1266.33 ms | 21.59 ms |
| 0ac1eed | 1278.51 ms | 1285.29 ms | 6.78 ms |
| 3d305b9 | 1230.29 ms | 1247.39 ms | 17.10 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f056db1 | 8.38 MiB | 9.73 MiB | 1.35 MiB |
| 6d317ea | 8.15 MiB | 9.12 MiB | 986.26 KiB |
| ebfead1 | 8.10 MiB | 9.16 MiB | 1.07 MiB |
| 8609bd8 | 8.28 MiB | 9.34 MiB | 1.06 MiB |
| 33d0587 | 8.29 MiB | 9.38 MiB | 1.09 MiB |
| 5112c69 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| eb1a7c1 | 8.15 MiB | 9.13 MiB | 1000.10 KiB |
| 98d9a4a | 8.33 MiB | 9.62 MiB | 1.29 MiB |
| 0ac1eed | 8.10 MiB | 9.16 MiB | 1.07 MiB |
| 3d305b9 | 8.33 MiB | 9.63 MiB | 1.29 MiB |
Previous results on branch: feat/support-allow-urls-deny-urls
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5598f4c | 1246.48 ms | 1269.82 ms | 23.34 ms |
| e5a3315 | 1242.47 ms | 1263.29 ms | 20.82 ms |
| a4c0d59 | 1241.98 ms | 1264.47 ms | 22.49 ms |
| 10639ce | 1255.00 ms | 1273.60 ms | 18.60 ms |
| 1ec7235 | 1239.10 ms | 1255.81 ms | 16.71 ms |
| 8523a6d | 1260.88 ms | 1284.26 ms | 23.38 ms |
| 5e7ccc1 | 1242.98 ms | 1260.53 ms | 17.55 ms |
| 99a6f98 | 1254.55 ms | 1269.64 ms | 15.09 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5598f4c | 8.38 MiB | 9.71 MiB | 1.33 MiB |
| e5a3315 | 8.38 MiB | 9.73 MiB | 1.35 MiB |
| a4c0d59 | 8.38 MiB | 9.71 MiB | 1.33 MiB |
| 10639ce | 8.38 MiB | 9.73 MiB | 1.35 MiB |
| 1ec7235 | 8.38 MiB | 9.71 MiB | 1.33 MiB |
| 8523a6d | 8.38 MiB | 9.71 MiB | 1.33 MiB |
| 5e7ccc1 | 8.38 MiB | 9.71 MiB | 1.33 MiB |
| 99a6f98 | 8.38 MiB | 9.73 MiB | 1.35 MiB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2271 +/- ##
==========================================
+ Coverage 88.14% 91.01% +2.87%
==========================================
Files 245 73 -172
Lines 8442 2337 -6105
==========================================
- Hits 7441 2127 -5314
+ Misses 1001 210 -791 ☔ View full report in Codecov by Sentry. |
martinhaintz
requested review from
stefanosiano and
buenaflor
as code owners
buenaflor
approved these changes
Sep 9, 2024
martinhaintz
added a commit
that referenced
this pull request
Sep 10, 2024
…tsentry/sentry-dart into fix/flutter-multiview-support * 'fix/flutter-multiview-support' of https://github.com/getsentry/sentry-dart: Update CHANGELOG.md release: 8.9.0 chore: rename errorSampleRate to onErrorSampleRate (#2270) fix: repost replay screenshots on android while idle (#2275) feat: capture touch breadcrumbs for all buttons (#2242) Symbolicate Dart stacktrace on Flutter Android and iOS without debug images from native sdks (#2256) Fix: Support allowUrls, denyUrls (#2271) chore(deps): update Flutter SDK (metrics) to v3.24.2 (#2272)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
change matching from absPath to window.location
#skip-changelog
💡 Motivation and Context
fixing #2227
💚 How did you test it?
unittest
📝 Checklist
sendDefaultPiiis enabled