-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v9]: bump drift min version and use QueryInterceptor
instead of QueryExecutor
#2679
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v9 #2679 +/- ##
==========================================
+ Coverage 88.24% 88.38% +0.14%
==========================================
Files 263 263
Lines 8918 8837 -81
==========================================
- Hits 7870 7811 -59
+ Misses 1048 1026 -22 ☔ View full report in Codecov by Sentry. |
static const String dbSystemKey = 'db.system'; | ||
static const String dbNameKey = 'db.name'; | ||
|
||
static const String dbSystemSqlite = 'db.sqlite'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbd in other PR, add other db systems here
} | ||
|
||
@internal | ||
class SentrySpanData { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbd in other PR, remove SpanDataConvention
and put the constants here
📜 Description
💡 Motivation and Context
Use better api for instrumenting drift operations
Part of #2165
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps
Deprecate it in the main branch