Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9]: bump drift min version and use QueryInterceptor instead of QueryExecutor #2679

Merged
merged 34 commits into from
Feb 18, 2025

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Feb 10, 2025

📜 Description

💡 Motivation and Context

Use better api for instrumenting drift operations

Part of #2165

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Deprecate it in the main branch

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 92.72727% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.38%. Comparing base (ea071ab) to head (8b59210).
Report is 2 commits behind head on v9.

Files with missing lines Patch % Lines
dart/lib/src/constants.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v9    #2679      +/-   ##
==========================================
+ Coverage   88.24%   88.38%   +0.14%     
==========================================
  Files         263      263              
  Lines        8918     8837      -81     
==========================================
- Hits         7870     7811      -59     
+ Misses       1048     1026      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

static const String dbSystemKey = 'db.system';
static const String dbNameKey = 'db.name';

static const String dbSystemSqlite = 'db.sqlite';
Copy link
Contributor Author

@buenaflor buenaflor Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbd in other PR, add other db systems here

@buenaflor buenaflor requested a review from denrase February 12, 2025 14:42
@buenaflor buenaflor marked this pull request as ready for review February 12, 2025 14:42
}

@internal
class SentrySpanData {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbd in other PR, remove SpanDataConvention and put the constants here

drift/example/example.dart Show resolved Hide resolved
drift/lib/src/constants.dart Outdated Show resolved Hide resolved
drift/lib/src/sentry_query_interceptor.dart Outdated Show resolved Hide resolved
drift/lib/src/sentry_query_interceptor.dart Outdated Show resolved Hide resolved
drift/lib/src/sentry_span_helper.dart Outdated Show resolved Hide resolved
@buenaflor
Copy link
Contributor Author

updated impl to support nested transactions

image

@buenaflor buenaflor requested a review from denrase February 14, 2025 15:42
drift/lib/src/sentry_span_helper.dart Outdated Show resolved Hide resolved
@buenaflor buenaflor requested a review from denrase February 17, 2025 15:08
@buenaflor buenaflor merged commit a685eaf into v9 Feb 18, 2025
148 of 149 checks passed
@buenaflor buenaflor deleted the v9-task/bump-drift-and-use-interceptor branch February 18, 2025 09:27
@vaind vaind mentioned this pull request Feb 18, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants