Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: message of frames tracking warning #2704

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Feb 11, 2025

📜 Description

Fixes wrong warning message in frames tracking integration

💡 Motivation and Context

Closes #2703

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.09%. Comparing base (57323e5) to head (47b6f19).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2704      +/-   ##
==========================================
+ Coverage   88.99%   92.09%   +3.09%     
==========================================
  Files         263       91     -172     
  Lines        8921     2946    -5975     
==========================================
- Hits         7939     2713    -5226     
+ Misses        982      233     -749     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 437.36 ms 537.31 ms 99.95 ms
Size 6.46 MiB 7.48 MiB 1.02 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
cd16818 316.57 ms 375.19 ms 58.62 ms
42f6e7e 308.71 ms 360.06 ms 51.35 ms
2261c15 370.00 ms 455.88 ms 85.88 ms
3ad66e4 406.90 ms 481.48 ms 74.58 ms
4477d2e 392.75 ms 472.69 ms 79.94 ms
fcd1ee4 298.96 ms 376.04 ms 77.09 ms
d089990 361.67 ms 442.50 ms 80.83 ms
4c13d97 455.34 ms 509.42 ms 54.08 ms
7359546 458.04 ms 522.60 ms 64.56 ms
24b6e60 440.64 ms 557.96 ms 117.32 ms

App size

Revision Plain With Sentry Diff
cd16818 6.26 MiB 7.20 MiB 956.08 KiB
42f6e7e 6.27 MiB 7.20 MiB 956.06 KiB
2261c15 6.27 MiB 7.20 MiB 957.75 KiB
3ad66e4 6.33 MiB 7.26 MiB 947.04 KiB
4477d2e 6.33 MiB 7.26 MiB 950.38 KiB
fcd1ee4 6.16 MiB 7.13 MiB 1000.85 KiB
d089990 6.34 MiB 7.28 MiB 967.79 KiB
4c13d97 6.49 MiB 7.56 MiB 1.07 MiB
7359546 6.46 MiB 7.48 MiB 1.01 MiB
24b6e60 6.33 MiB 7.26 MiB 950.14 KiB

Previous results on branch: fix/warning-message-frames-tracking

Startup times

Revision Plain With Sentry Diff
057f8a6 465.20 ms 539.20 ms 74.00 ms

App size

Revision Plain With Sentry Diff
057f8a6 6.46 MiB 7.48 MiB 1.02 MiB

Copy link
Contributor

github-actions bot commented Feb 11, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1256.14 ms 1269.33 ms 13.18 ms
Size 8.42 MiB 9.91 MiB 1.49 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
cecd4ed 1232.88 ms 1250.65 ms 17.78 ms
0ac1eed 1278.51 ms 1285.29 ms 6.78 ms
9f9f94f 1268.33 ms 1284.73 ms 16.41 ms
4b29d6e 1208.18 ms 1230.92 ms 22.73 ms
0aaa46e 1256.39 ms 1276.41 ms 20.02 ms
ed2ae08 1222.10 ms 1226.57 ms 4.47 ms
f4cc744 1274.57 ms 1290.79 ms 16.22 ms
613760b 1263.10 ms 1277.27 ms 14.16 ms
7fd33d3 1241.92 ms 1265.47 ms 23.55 ms
df16b96 1255.24 ms 1259.40 ms 4.16 ms

App size

Revision Plain With Sentry Diff
cecd4ed 8.38 MiB 9.75 MiB 1.37 MiB
0ac1eed 8.10 MiB 9.16 MiB 1.07 MiB
9f9f94f 8.15 MiB 9.15 MiB 1020.76 KiB
4b29d6e 8.32 MiB 9.38 MiB 1.05 MiB
0aaa46e 8.29 MiB 9.38 MiB 1.09 MiB
ed2ae08 8.28 MiB 9.34 MiB 1.06 MiB
f4cc744 8.16 MiB 9.16 MiB 1.01 MiB
613760b 8.15 MiB 9.13 MiB 1000.46 KiB
7fd33d3 8.38 MiB 9.78 MiB 1.40 MiB
df16b96 8.10 MiB 9.16 MiB 1.06 MiB

Previous results on branch: fix/warning-message-frames-tracking

Startup times

Revision Plain With Sentry Diff
057f8a6 1262.31 ms 1277.10 ms 14.80 ms

App size

Revision Plain With Sentry Diff
057f8a6 8.42 MiB 9.91 MiB 1.48 MiB

@buenaflor buenaflor requested a review from denrase February 12, 2025 12:17
@buenaflor buenaflor merged commit 9e3070e into main Feb 12, 2025
61 checks passed
@buenaflor buenaflor deleted the fix/warning-message-frames-tracking branch February 12, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Method Reference in Error Message for FramesTrackingIntegration
2 participants