-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v9] Remove max response body size #2709
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v9 #2709 +/- ##
===========================================
+ Coverage 67.94% 88.50% +20.55%
===========================================
Files 15 262 +247
Lines 443 8758 +8315
===========================================
+ Hits 301 7751 +7450
- Misses 142 1007 +865 ☔ View full report in Codecov by Sentry. |
@denrase nice! could you also prepare a PR deprecating these for the main branch pls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, only got one question
CHANGELOG.md
Outdated
@@ -11,6 +11,9 @@ | |||
- Remove `options.autoAppStart` and `setAppStartEnd` ([#2680](https://github.com/getsentry/sentry-dart/pull/2680)) | |||
- Add hint for transactions ([#2675](https://github.com/getsentry/sentry-dart/pull/2675)) | |||
- `BeforeSendTransactionCallback` now has a `Hint` parameter | |||
- Remove max response body size ([#2709](https://github.com/getsentry/sentry-dart/pull/2709)) | |||
- Responses are now only attached if size is below ~15mb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and also pls mention that this is currently only applicable for the dio integration, not our http integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
our http integration doesn't support capturing the response data generally, we could add that feature later at some point
@buenaflor The contexts still have response. Should we deprecate it? |
@denrase I believe so, could you check if other sdks have this in the contexts |
https://develop.sentry.dev/sdk/data-model/event-payloads/contexts/#response-context we can leave the response, we just have to be clear that we will not add the response body/data automatically, the user has to do that themselves via the hints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice lgtm
📜 Description
💡 Motivation and Context
Closes #2637
Closes #2638
💚 How did you test it?
Tests
📝 Checklist
sendDefaultPii
is enabled