-
-
Notifications
You must be signed in to change notification settings - Fork 263
Set Firebase Remote Config flags on integration initialization #3008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Set Firebase Remote Config flags on integration initialization #3008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution! lgtm but I'll let @denrase give the final approval
firebase_remote_config/test/src/sentry_firebase_remote_config_integration_test.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Giancarlo Buenaflor <[email protected]>
only missing piece is to add a changelog entry
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some smaller refactoring suggestions. Thank you for your contribution! 🙇
firebase_remote_config/lib/src/sentry_firebase_remote_config_integration.dart
Outdated
Show resolved
Hide resolved
firebase_remote_config/test/src/sentry_firebase_remote_config_integration_test.dart
Show resolved
Hide resolved
…-flag-initialization' into feat/firebase-remote-config-flag-initialization
📜 Description
Calls
Sentry.addFeatureFlag
on initialization ofSentryFirebaseRemoteConfigIntegration
.💡 Motivation and Context
Fixes #3007
💚 How did you test it?
flutter test firebase_remote_config/test/src/sentry_firebase_remote_config_integration_test.dart
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps
N/A