Skip to content

Set Firebase Remote Config flags on integration initialization #3008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kurtmarcink
Copy link

📜 Description

Calls Sentry.addFeatureFlag on initialization of SentryFirebaseRemoteConfigIntegration.

💡 Motivation and Context

Fixes #3007

💚 How did you test it?

flutter test firebase_remote_config/test/src/sentry_firebase_remote_config_integration_test.dart

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

N/A

Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution! lgtm but I'll let @denrase give the final approval

Co-authored-by: Giancarlo Buenaflor <[email protected]>
@buenaflor
Copy link
Contributor

only missing piece is to add a changelog entry

### Features

- Set Firebase Remote Config flags on integration initialization ([#3008](https://github.com/getsentry/sentry-dart/pull/3008))

Copy link
Collaborator

@denrase denrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some smaller refactoring suggestions. Thank you for your contribution! 🙇

…-flag-initialization' into feat/firebase-remote-config-flag-initialization
@kurtmarcink kurtmarcink requested a review from denrase June 27, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SentryFirebaseRemoteConfigIntegration should not wait for config update to set feature flags
3 participants