Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Liza Mock <[email protected]>
  • Loading branch information
krystofwoldrich and lizokm committed Feb 14, 2024
1 parent 30b01e3 commit 8c3d285
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
8 changes: 3 additions & 5 deletions docs/platforms/react-native/metrics/index.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,9 @@ To emit a gauge, do the following:

## Supported Performance Metric Units

You can pass a unit as a optional parameter of the third argument of the `increment`, `distribution`, `set`, and `gauge` methods.
Adding a unit as a metric parameter will give meaning to what may otherwise look like abstract numbers. It also allows Sentry to offer controls - unit conversions, filters, and so on - based on the unit you select. You can pass a unit as an optional parameter of the third argument of the `increment`, `distribution`, `set`, and `gauge` methods. If a value has no units, you can supply an empty string or `none`.

Units augment metric values by giving meaning to what otherwise might be abstract numbers. Adding units also allows Sentry to offer controls - unit conversions, filters, and so on - based on those units. For values that are unitless, you can supply an empty string or `none`.

These following units are understood by the Sentry backend, but you can supply any arbitrary units you want.
The following units are understood by the Sentry backend, but you can add any arbitrary unit you want.

### Duration Units

Expand Down Expand Up @@ -84,4 +82,4 @@ These following units are understood by the Sentry backend, but you can supply a
- `ratio`
- `percent`

If you want to explore further, you can find details about supported units in our [event ingestion documentation](https://getsentry.github.io/relay/relay_metrics/enum.MetricUnit.html).
You can find additional details about supported units in our [event ingestion documentation](https://getsentry.github.io/relay/relay_metrics/enum.MetricUnit.html).
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Note>

Metrics for React Native are supported with Sentry React Native SDK version `5.19.0` and above.
Metrics for React Native are supported in Sentry React Native SDK version `5.19.0` and above.

</Note>

0 comments on commit 8c3d285

Please sign in to comment.