Skip to content

Commit

Permalink
fix(changelog): use absolute url favicon (#11113)
Browse files Browse the repository at this point in the history
* try absolute favicon for prod

* chore: update img-src csp for absolute favicon url

* chore: add comment
  • Loading branch information
chargome committed Aug 16, 2024
1 parent 9aeaacb commit 9f539aa
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
Binary file removed apps/changelog/src/app/favicon.ico
Binary file not shown.
6 changes: 5 additions & 1 deletion apps/changelog/src/app/layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ export const metadata: Metadata = {
title: 'Home',
icons: {
icon:
process.env.NODE_ENV === 'production' ? '/favicon.ico' : '/favicon_localhost.png',
// we use the absolute url (for the alternative prod domain),
// otherwise we run into the issue that sentry.io/changelog will not find the favicon
process.env.NODE_ENV === 'production'
? 'https://changelog.sentry.dev/favicon.ico'
: '/favicon_localhost.png',
},
openGraph: {
images: '/img/hero.png',
Expand Down
4 changes: 2 additions & 2 deletions apps/changelog/vercel.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@
},
{
"key": "Content-Security-Policy-Report-Only",
"value": "default-src 'none'; font-src 'self'; style-src 'self' 'unsafe-inline'; script-src 'self' plausible.io 'unsafe-inline' 'unsafe-eval' 'report-sample'; img-src 'self' storage.googleapis.com; worker-src blob:; connect-src o1.ingest.us.sentry.io plausible.io 'self' sentry.sentry.io; report-uri https://o1.ingest.us.sentry.io/api/4507670276341760/security/?sentry_key=e90f5ea060a4102c0a4c50c740e43ae1;"
"value": "default-src 'none'; font-src 'self'; style-src 'self' 'unsafe-inline'; script-src 'self' plausible.io 'unsafe-inline' 'unsafe-eval' 'report-sample'; img-src 'self' storage.googleapis.com; worker-src blob:; connect-src o1.ingest.us.sentry.io plausible.io 'self' changelog.sentry.dev sentry.sentry.io; report-uri https://o1.ingest.us.sentry.io/api/4507670276341760/security/?sentry_key=e90f5ea060a4102c0a4c50c740e43ae1;"
}
]
}
],
"trailingSlash": true
}
}

0 comments on commit 9f539aa

Please sign in to comment.