Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(billing): Update spend notifications documentation #10076

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

dashed
Copy link
Member

@dashed dashed commented May 17, 2024

Prepare and update documentation in anticipation of the spend notifications feature rollout.

@dashed dashed requested a review from a team May 17, 2024 19:56
@dashed dashed self-assigned this May 17, 2024
Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 10:30pm

Copy link

codecov bot commented May 17, 2024

Bundle Report

Changes will increase total bundle size by 15.6kB ⬆️

Bundle name Size Change
sentry-docs-server 7.57MB 15.58kB ⬆️
sentry-docs-edge-server 478.9kB 27 bytes ⬆️
sentry-docs-client 6.21MB 8 bytes ⬇️

@@ -8,7 +8,7 @@ Sentry sends you notifications regarding workflow activities, [release deploys](

- [Workflow](#workflow-notifications): Activity involving user actions and state changes on issues. This includes activities such as issue resolution, assignment, comments, and regressions.
- [Deploy](#deploy-notifications): When a release you have commits on is deployed.
- [Quota](#quota-notifications): Approaching quotas, exceeded quotas, and spike protection.
- [Spend](#spend-notifications): Reserved volume warning, depleted quotas, and on-demand capacity usage notifications.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm the copy? There seems to be a shift towards "pre-paid" instead of "reserved" and "pay as you go" instead of "on-demamd".
Otherwise, LGTM.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Reserved" is fine, and is a concept we want to keep the same in AM2 and AM3. We're not planning on changing that to "Pre-paid".

"On-Demand" is how AM2 customers see things. However for AM3 orgs, we should change this to "Pay As You Go". Since docs should reflect the latest plan (whereas in-app we show based on their plan), this should be updated from "On-Demand" to "Pay As You Go"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Does the copy still need to be changed here?

This pull request updates the current docs for the Spend Notifications ready to be released for AM1 and AM2 organizations.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This copy looks good as is. We will revisit "PAYG" changes with Docs team prior to AM3 launch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dashed @brianthi any updates on this?

dashed added a commit to getsentry/sentry that referenced this pull request May 21, 2024
Update "Learn More" link that will point to updated documentation in
getsentry/sentry-docs#10076.

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
@lizokm lizokm self-requested a review May 23, 2024 15:17
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small tweaks. Thanks for updating.

docs/product/alerts/notifications/index.mdx Outdated Show resolved Hide resolved
docs/product/alerts/notifications/index.mdx Outdated Show resolved Hide resolved
@dashed dashed force-pushed the spend-notifications/update-docs branch from ff5b469 to f489a2a Compare June 11, 2024 22:12
@dashed dashed merged commit 756f294 into master Jun 13, 2024
6 checks passed
@dashed dashed deleted the spend-notifications/update-docs branch June 13, 2024 19:06
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants