Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Use default prettier config for formatting code blocks instead of repository config #10194

Merged
merged 1 commit into from
May 29, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented May 29, 2024

We do not want "our" (as in, the docs developers) prettier config to be what dictates the content of code blocks, but rather we want to stick to the default prettier config as much as possible because that is what people are used to.

Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 3:25pm

Copy link

codecov bot commented May 29, 2024

Bundle Report

Changes will decrease total bundle size by 505 bytes ⬇️

Bundle name Size Change
sentry-docs-server 7.43MB 494 bytes ⬇️
sentry-docs-client 6.19MB 8 bytes ⬇️
sentry-docs-edge-server 461.86kB 3 bytes ⬇️

Copy link
Collaborator

@a-hariti a-hariti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@lforst lforst merged commit 683c503 into master May 29, 2024
8 checks passed
@lforst lforst deleted the lforst-default-prettier-config branch May 29, 2024 16:22
matejminar pushed a commit that referenced this pull request Jun 6, 2024
a-hariti pushed a commit that referenced this pull request Jun 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants