Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apple): Use id<SentrySpan> in performance obj-c code snippets #10333

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

krystofwoldrich
Copy link
Member

I've noticed our Apple docs mention Span protocol, but that didn't work for me. Should it be SentrySpan?

Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 8:33am

@krystofwoldrich
Copy link
Member Author

@philipphofmann @brustolin Feel free to close this, in case it doesn't make sense.

I created some custom span with sentry-cocoa and I've only found SentrySpan.

Copy link

codecov bot commented Jun 10, 2024

Bundle Report

Changes will decrease total bundle size by 12 bytes ⬇️

Bundle name Size Change
sentry-docs-server 7.44MB 3 bytes ⬇️
sentry-docs-client 6.19MB 6 bytes ⬇️
sentry-docs-edge-server 462.26kB 3 bytes ⬇️

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it should be SentrySpan. I guess hardly anybody uses ObjC anymore 😄. LGTM

@krystofwoldrich krystofwoldrich merged commit 5ab9df5 into master Jun 10, 2024
6 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/fix-apple-span branch June 10, 2024 11:23
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants