Add note about integrations to multiple clients js doc #10355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will decrease total bundle size by 1 bytes ⬇️
|
luc122c
suggested changes
Jun 12, 2024
mydea
approved these changes
Jun 12, 2024
s1gr1d
reviewed
Jun 12, 2024
| const client = new BrowserClient({ | ||
| dsn: "___PUBLIC_DSN___", | ||
| transport: makeFetchTransport, | ||
| stackParser: defaultStackParser, | ||
| integrations: defaultIntegrations, | ||
| integrations: integrations, |
There was a problem hiding this comment.
Maybe you want to write it this way, but I leave it up to you
Suggested change
| integrations: integrations, | |
| integrations, |
There was a problem hiding this comment.
I thought about this, but this makes it especially explicit we are passing in this variable here. I'll leave this syntax for people who are less familiar with JS.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Copy over integrations snippet from https://docs.sentry.io/platforms/javascript/best-practices/browser-extensions/ to https://docs.sentry.io/platforms/javascript/best-practices/multiple-sentry-instances/ page.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES