Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Apple): Updates Features/Experimental Features pages #10359

Merged
merged 4 commits into from
Jun 13, 2024
Merged

chore(Apple): Updates Features/Experimental Features pages #10359

merged 4 commits into from
Jun 13, 2024

Conversation

kahest
Copy link
Member

@kahest kahest commented Jun 11, 2024 •
edited
Loading

DESCRIBE YOUR PR

  • moves features that are not experimental anymore from Experimental features page to Features
  • updates Experimental features content
  • refactors links on Features page to use <PlatformLink> and <Link>

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@vercel Vercel
Copy link

vercel bot commented Jun 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 8:09am

@codecov Codecov
Copy link

codecov bot commented Jun 11, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 14 bytes ⬇️

Bundle name Size Change
sentry-docs-server 7.55MB 3 bytes ⬇️
sentry-docs-client 6.21MB 8 bytes ⬇️
sentry-docs-edge-server 478.9kB 3 bytes ⬇️

philipphofmann
philipphofmann approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kahest 💯

@kahest kahest requested a review from a team June 12, 2024 09:51
@kahest kahest mentioned this pull request Jun 12, 2024
Open
vivianyentran
vivianyentran approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this page! Added a suggestion

docs/platforms/apple/common/features/experimental-features.mdx Outdated Show resolved Hide resolved
docs/platforms/apple/common/features/experimental-features.mdx Outdated Show resolved Hide resolved
@kahest kahest merged commit c174fba into master Jun 13, 2024
6 checks passed
@kahest kahest deleted the kahest/apple-features branch June 13, 2024 08:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vivianyentran vivianyentran vivianyentran approved these changes

@philipphofmann philipphofmann philipphofmann approved these changes

@armcknight armcknight Awaiting requested review from armcknight

@brustolin brustolin Awaiting requested review from brustolin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kahest @philipphofmann @vivianyentran