Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling) wrong integration casing #10382

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Jun 12, 2024

The diffs are sad, but the casing used before was Sentry.BrowserProfilingIntegration whereas it should be Sentry.browserProfilingIntegration

Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 8:57pm

Copy link

codecov bot commented Jun 12, 2024

Bundle Report

Changes will decrease total bundle size by 12 bytes ⬇️

Bundle name Size Change
sentry-docs-server 7.55MB 3 bytes ⬇️
sentry-docs-edge-server 478.9kB 3 bytes ⬇️
sentry-docs-client 6.21MB 6 bytes ⬇️

Copy link
Contributor

@stephanie-anderson stephanie-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JonasBa - the contents in public/ must not be changed (and will be overwritten anyways). Please update the corresponding .mdx files in docs/, includes/ or platform-includes/

@stephanie-anderson
Copy link
Contributor

Hey @JonasBa - the contents in public/ must not be changed (and will be overwritten anyways). Please update the corresponding .mdx files in docs/, includes/ or platform-includes/

Sorry, found the reason for this. Will follow up with the Telemetry Experience team if this is still needed.

@JonasBa
Copy link
Member Author

JonasBa commented Jun 13, 2024

@stephanie-anderson we still need this because the docs on the sentry dashboard are still using this.

I found no other reference to these files in any mdx docs, so I assume they are the correct source and need to update them, else the in-app onboarding is broken.

@stephanie-anderson stephanie-anderson merged commit 9cc5ca5 into master Jun 13, 2024
6 checks passed
@stephanie-anderson stephanie-anderson deleted the jb/profiling/browser-profiling-casing branch June 13, 2024 16:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants