Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add <Expandable /> permalinks #10622

Merged
merged 5 commits into from
Jul 9, 2024
Merged

feat: add <Expandable /> permalinks #10622

merged 5 commits into from
Jul 9, 2024

Conversation

a-hariti
Copy link
Collaborator

@a-hariti a-hariti commented Jul 9, 2024

add a permalink option to the <Expandable /> component to render headers as links and show them up on the TOC.

Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 4:07pm

Copy link

codecov bot commented Jul 9, 2024

Bundle Report

Changes will increase total bundle size by 1.09kB ⬆️

Bundle name Size Change
sentry-docs-server 8.29MB 283 bytes ⬆️
sentry-docs-edge-server 250.13kB 3 bytes ⬇️
sentry-docs-client 7.87MB 806 bytes ⬆️

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

docs/contributing/pages/components.mdx Outdated Show resolved Hide resolved
docs/contributing/pages/components.mdx Outdated Show resolved Hide resolved
@@ -46,7 +46,7 @@ This is some content
</Expandable>

```markdown {tabTitle:Example}
<Expandable title="Thi is a title">
<Expandable title="This is a title">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lizokm

@lizokm lizokm merged commit 3835bb1 into master Jul 9, 2024
9 checks passed
@lizokm lizokm deleted the expandable-permalinks branch July 9, 2024 23:10
@chargome
Copy link
Member

@a-hariti Nice!

sentrivana pushed a commit that referenced this pull request Jul 16, 2024
* feat: add expandable permalinks

* disable text selection on Expandable header

* fix spacing

* Update docs/contributing/pages/components.mdx

* Update docs/contributing/pages/components.mdx

---------

Co-authored-by: Liza Mock <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants