Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Apple): Show Apple profiling pages only on supported platforms #10749

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

kahest
Copy link
Member

@kahest kahest commented Jul 16, 2024

DESCRIBE YOUR PR

On Apple platforms, we only officially support Profiling for iOS and macOS. This PR hides the Profiling page on the guides for the other platforms (tvOS, watchOS, visionOS).

Also created an issue to follow up with details on platform support, especially for hybrid (mobile) SDKs: getsentry/team-mobile#191

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 5:10pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Jul 16, 2024 5:10pm

@kahest kahest changed the title show apple profiling only on supported guides fix(Apple): Show Apple profiling pages only on supported platforms Jul 16, 2024
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@kahest kahest merged commit 446f095 into master Jul 16, 2024
8 checks passed
@kahest kahest deleted the kahest/apple-profiling-support-guides branch July 16, 2024 20:54
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants