Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Automatic preview cleanups #10785

Merged
merged 4 commits into from
Jul 23, 2024
Merged

feat: Automatic preview cleanups #10785

merged 4 commits into from
Jul 23, 2024

Conversation

chargome
Copy link
Member

closes #10695

@chargome chargome self-assigned this Jul 19, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 7:49am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 7:49am

@codecov Codecov
Copy link

codecov bot commented Jul 19, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 12 bytes ⬇️

Bundle name Size Change
sentry-docs-server 9.53MB 3 bytes ⬇️
sentry-docs-edge-server 255.23kB 3 bytes ⬇️
sentry-docs-client 8.18MB 6 bytes ⬇️

@chargome
Copy link
Member Author

Some notes:

  • due to vercel rate limiting the first run took hours locally and deleted almost 10k stale preview deployments, but all consecutive runs should be finished fairly quickly
  • we need to update/add the env vars used in the gh workflow before merging this

a-hariti
a-hariti approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@a-hariti a-hariti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@chargome chargome merged commit b3332de into master Jul 23, 2024
10 checks passed
@chargome chargome deleted the cg/preview-deployment-cleanup branch July 23, 2024 08:46
lforst pushed a commit that referenced this pull request Jul 24, 2024
@chargome @lforst
feat: Automatic preview cleanups (#10785)
224e1cb
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-hariti a-hariti a-hariti approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

@chargome chargome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stale preview deployments
2 participants
@chargome @a-hariti