Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(changelog): Bump Next.js to canary and Sentry SDK to latest #10876

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Jul 26, 2024

Bumps Next.js to a canary version so that we can test out newer Next.js features that are useful for instrumentation.

All the changes that look unrelated in this PR are actually things that started throwing errors in dev in the new version.

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ❌ Failed (Inspect) Jul 30, 2024 8:28am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 8:28am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 8:28am

Copy link

codecov bot commented Jul 26, 2024

Bundle Report

Changes will increase total bundle size by 342.83kB ⬆️

Bundle name Size Change
sentry-docs-server 9.87MB 330.41kB ⬆️
sentry-docs-edge-server 259.17kB 3.81kB ⬆️
sentry-docs-client 8.19MB 8.62kB ⬆️

@lforst lforst changed the title deps(changelog): Bump Next.js to canary deps(changelog): Bump Next.js to canary and Sentry SDK to latest Jul 29, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be .env.example? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I purposefully added this. You probably already know this but .env.development will get picked up if you run next dev which I hope will save people time and confusion when they try to run the dev server for the changelog for the first time.

@@ -21,15 +21,14 @@
"@radix-ui/react-icons": "^1.3.0",
"@radix-ui/react-toolbar": "^1.0.4",
"@radix-ui/themes": "^2.0.3",
"@sentry/nextjs": "^8.8.0",
"@spotlightjs/spotlight": "^2.1.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Why did you remove spotlight?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was one more thing I needed to get working with the new Next.js version. I will add it back in a follow-up. But good that you bring it up!

@lforst lforst merged commit f3d60dc into master Jul 29, 2024
11 checks passed
@lforst lforst deleted the lforst-bump-changelog-nextjs-version branch July 29, 2024 09:05
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants