Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tracing): Add missing searchable span properties #10879

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

0Calories
Copy link
Member

DESCRIBE YOUR PR

Adds several missing properties for span searching to the documentation. Check out getsentry/sentry#74787 to see the PR that adds descriptions for these search properties

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@0Calories 0Calories self-assigned this Jul 26, 2024
Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ❌ Failed (Inspect) Sep 25, 2024 6:14pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 6:14pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 6:14pm

Copy link

codecov bot commented Jul 26, 2024

Bundle Report

Changes will increase total bundle size by 52.34kB (0.37%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server 7.49MB 52.35kB (0.7%) ⬆️
sentry-docs-edge-server 254.5kB 3 bytes (-0.0%) ⬇️
sentry-docs-client 6.39MB 6 bytes (-0.0%) ⬇️

@getsantry
Copy link
Contributor

getsantry bot commented Aug 17, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Aug 17, 2024
@getsantry getsantry bot closed this Aug 25, 2024
@0Calories
Copy link
Member Author

Can I get some eyes on this please?

@0Calories 0Calories reopened this Aug 29, 2024
@0Calories 0Calories requested review from vivianyentran and lizokm and removed request for stephanie-anderson and lizokm August 29, 2024 18:57
@getsantry getsantry bot closed this Sep 11, 2024
@0Calories 0Calories reopened this Sep 16, 2024
@getsantry getsantry bot removed the Stale label Sep 16, 2024
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small suggestions. Thanks for adding!

docs/concepts/search/searchable-properties/spans.mdx Outdated Show resolved Hide resolved
@0Calories
Copy link
Member Author

Thanks! Suggestions look good

@0Calories 0Calories removed the request for review from vivianyentran September 25, 2024 17:57
@0Calories 0Calories merged commit 7a9f88c into master Sep 25, 2024
9 of 10 checks passed
@0Calories 0Calories deleted the docs/span-search-properties branch September 25, 2024 18:18
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants