Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(browserapierrors): Correction symbol #10882

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

xyyjk
Copy link
Contributor

@xyyjk xyyjk commented Jul 27, 2024

The key segmentation of the JS object should be a comma.

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

The key segmentation of the JS object should be a comma.
Copy link

vercel bot commented Jul 27, 2024

@xyyjk is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@lizokm lizokm requested a review from a-hariti July 29, 2024 04:35
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 10:35am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 10:35am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 10:35am

@a-hariti
Copy link
Collaborator

Thanks for the fix @xyyjk!

@a-hariti a-hariti enabled auto-merge (squash) July 29, 2024 10:27
@a-hariti a-hariti merged commit c34816d into getsentry:master Jul 29, 2024
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants