Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(self-hosted): move readme contents #10883

Merged

Conversation

aldy505
Copy link
Contributor

@aldy505 aldy505 commented Jul 27, 2024

DESCRIBE YOUR PR

Dupe of getsentry/develop#1339

Closes getsentry/self-hosted#1996

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Jul 27, 2024

@aldy505 is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 6:59pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 6:59pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 6:59pm

@aldy505
Copy link
Contributor Author

aldy505 commented Aug 7, 2024

/cc @hubertdeng123 @azaslavsky

@aldy505
Copy link
Contributor Author

aldy505 commented Aug 15, 2024

Any feedbacks from devinfra team? @hubertdeng123 @joshuarli

P.S. I also have a few PRs for updating self-hosted related docs. See https://github.com/getsentry/sentry-docs/pulls?q=is%3Apr+self-hosted+is%3Aopen+author%3Aaldy505

@aldy505
Copy link
Contributor Author

aldy505 commented Aug 23, 2024

Another ping @joshuarli @hubertdeng123

@aldy505
Copy link
Contributor Author

aldy505 commented Aug 26, 2024

another ping @hubertdeng123

develop-docs/self-hosted/index.mdx Outdated Show resolved Hide resolved
develop-docs/self-hosted/index.mdx Outdated Show resolved Hide resolved
@aldy505
Copy link
Contributor Author

aldy505 commented Aug 30, 2024

ping @hubertdeng123 @joshuarli

Copy link
Member

@joshuarli joshuarli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, very well done.

self-hosted readme removed here: getsentry/self-hosted#3307

@joshuarli joshuarli merged commit 2fd877c into getsentry:master Sep 3, 2024
9 checks passed
@aldy505 aldy505 deleted the docs/self-hosted/move-readme-contents branch September 5, 2024 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate README content to dev docs
3 participants