Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(changelog): Add back spotlight #10894

Merged
merged 2 commits into from
Jul 29, 2024
Merged

feat(changelog): Add back spotlight #10894

merged 2 commits into from
Jul 29, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Jul 29, 2024

Adds back spotlight to the changelog.

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 0:17am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 0:17am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 0:17am

Copy link

codecov bot commented Jul 29, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes ⬇️

Bundle name Size Change
sentry-docs-server 9.83MB 6 bytes ⬇️
sentry-docs-edge-server 259.17kB 3 bytes ⬇️
sentry-docs-client 8.19MB 6 bytes ⬇️

Copy link
Collaborator

@a-hariti a-hariti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qq: I had done a bundle analysis a while back and noticed that Spotlight ended up in the production bundle

do you think this way of initialization fixes it @lforst ?

@lforst
Copy link
Member Author

lforst commented Jul 29, 2024

qq: I had done a bundle analysis a while back and noticed that Spotlight ended up in the production bundle

I think as long as stuff is guarded with process.env.NODE_ENV === 'production' things should tree shake out in prod. Note that I didn't change anything from before here!

@lforst lforst merged commit cd3b609 into master Jul 29, 2024
11 checks passed
@lforst lforst deleted the lforst-add-back-spotlight branch July 29, 2024 12:31
@a-hariti
Copy link
Collaborator

It didn't shake out for some reason, will take a closer look later 👍

@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants