Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default value for the config key environment in the java sdk #10911

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Default value for the config key environment in the java sdk #10911

merged 4 commits into from
Sep 3, 2024

Conversation

rudolfgrauberger
Copy link
Contributor

Adds the default value of the environment config key as in https://github.com/getsentry/sentry-java/blob/3a89243fa0ec48fc16193070c2224833d94f9156/sentry/src/main/java/io/sentry/SentryOptions.java#L58 specified and used in https://github.com/getsentry/sentry-java/blob/3a89243fa0ec48fc16193070c2224833d94f9156/sentry/src/main/java/io/sentry/SentryOptions.java#L852

DESCRIBE YOUR PR

I add the default value for the config key environment.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel Vercel
Copy link

vercel bot commented Jul 30, 2024

@rudolfgrauberger is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@rudolfgrauberger rudolfgrauberger changed the title Update options.mdx Default value for the config key environment in the java sdk Jul 30, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ❌ Failed (Inspect) Sep 2, 2024 5:00am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 5:00am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 5:00am

@lizokm lizokm requested a review from adinauer July 31, 2024 23:51
lizokm
lizokm approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to our docs!

docs/platforms/java/common/configuration/options.mdx Outdated Show resolved Hide resolved
docs/platforms/java/common/configuration/options.mdx Outdated Show resolved Hide resolved
@getsantry
Copy link
Contributor

getsantry bot commented Aug 22, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Aug 22, 2024
@rudolfgrauberger
Copy link
Contributor Author

What can I do/contribute so that it is accepted or continues? It seems that it is out of my hands.

adinauer
adinauer approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM

@adinauer adinauer enabled auto-merge (squash) August 22, 2024 11:49
@adinauer
Copy link
Member

@lizokm I'm unable to approve the vercel stuff, can you help out 🙏

@getsantry getsantry bot closed this Aug 30, 2024
auto-merge was automatically disabled August 30, 2024 07:00

Pull request was closed

@rudolfgrauberger
Copy link
Contributor Author

?

@adinauer
Copy link
Member

Not sure either what's going on here. I'll try to find out.

@adinauer adinauer reopened this Aug 30, 2024
@adinauer
Copy link
Member

Ah it was just the stale bot (#10911 (comment)). Sorry for the delays here, I'll try to get this merged soon.

@adinauer
Copy link
Member

adinauer commented Sep 2, 2024

We're having some technical issues. Gonna try again in a bit.

@adinauer adinauer merged commit e178f13 into getsentry:master Sep 3, 2024
10 checks passed
@adinauer
Copy link
Member

adinauer commented Sep 3, 2024

Thank you for the PR and your patience @rudolfgrauberger !

Zylphrex pushed a commit that referenced this pull request Sep 4, 2024
@rudolfgrauberger @adinauer
@lizokm @Zylphrex
Default value for the config key environment in the java sdk (#10911)
3cd2104 
* Update options.mdx

Adds the default value of the `environment` config key as in https://github.com/getsentry/sentry-java/blob/3a89243fa0ec48fc16193070c2224833d94f9156/sentry/src/main/java/io/sentry/SentryOptions.java#L58 specified and used in https://github.com/getsentry/sentry-java/blob/3a89243fa0ec48fc16193070c2224833d94f9156/sentry/src/main/java/io/sentry/SentryOptions.java#L852

* Apply suggestions from code review

Co-authored-by: Liza Mock <[email protected]>

---------

Co-authored-by: Alexander Dinauer <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Alexander Dinauer <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adinauer adinauer adinauer approved these changes

@lizokm lizokm lizokm approved these changes

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rudolfgrauberger @adinauer @lizokm