-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Capacitor): Add migration guide for new version #10987
Conversation
@lucas-zimerman is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
Should I also add an information like this? https://docs.sentry.io/platforms/javascript/guides/angular/#angular-version-compatibility despite the page mentioning that older versions of Angular should use V7, the docs only only shows the documentation of V8 so it may generate confusion to users sticking with V7. Our Capacitor SDK only supports Angular as low as 10, so we could mention that users should stick with Capacitor V0 for Angular 10 to - 13 and V1 for Angular 14 or higher. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@chargome I added @getsentry/team-web-sdk-frontend as reviewer - please rope in other reviewers if needed 🙏 |
Yes I think that would help users understand 👍 |
Besides the Angular versions mentioned above, the guide migration guide looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
docs/platforms/javascript/common/migration/v7-to-v8/v8-new-performance-api.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! 🚀
DESCRIBE YOUR PR
The next major version of Sentry Capacitor will also use Sentry Javascript SDK V8 where both includes break changes, this PR aims to add a migration guide for both Capacitor and the Sibling SDKs.
I also removed the deprecated setup of Capacitor 2 that we will no longer support and also a small refactor on v8-new-performance-api to make the file smaller to read on the code review.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
I checked that locally it is building and displaying correctly.
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
EXTRA RESOURCES