Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ignoreErrors and ignoreTransactions for Dart #10989

Conversation

martinhaintz
Copy link
Collaborator

DESCRIBE YOUR PR

Based on this PR from sentry-dart 2207 I added the ignoreErrors and ignoreTransactions option to the docs.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Aug 6, 2024

@martinhaintz is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 10:01am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 10:01am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 10:01am

Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! pre-emptively approving this, we can merge this when the next release is out

@martinhaintz
Copy link
Collaborator Author

I improved the misleading code samples to make the difference between string comparison and regex more clear.

@buenaflor
Copy link
Contributor

@vivianyentran could you rerun the vercel ci pls

@kahest
Copy link
Member

kahest commented Aug 12, 2024

@buenaflor I re-ran Vercel - you can ping me as well if you need Vercel deployments :)

@buenaflor buenaflor merged commit 30dc4cb into getsentry:master Aug 13, 2024
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants