Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sveltekit): Document new wrapServerRouteWithSentry wrapper #10990

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Aug 6, 2024

DESCRIBE YOUR PR

This PR adds documentation for the new wrapServerRouteWithSentry function we added in getsentry/sentry-javascript#13247. While adding this, I slightly restructured the Manual Setup page of the SvelteKit guide to now have "Automatic Instrumentation" and "Manual Instrumentation" headings on the same level.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 9:36am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 9:36am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 9:36am


<Note>

Available since version `7.91.0`
Available since `8.24.0`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder for myself to double check that this is the actual version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like it's 8.25.0

Copy link

codecov bot commented Aug 6, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes ⬇️

Bundle name Size Change
sentry-docs-server 8.26MB 6 bytes ⬇️
sentry-docs-edge-server 254.16kB 3 bytes ⬇️
sentry-docs-client 6.25MB 6 bytes ⬇️


<Note>

Available since version `7.91.0`
Available since `8.24.0`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like it's 8.25.0

```

##### Disable Client-side `fetch` Proxy Script
```typescript {filename:+server.ts} {1,3}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this duplicated for ts and js?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because you can use JS and TS simultaneously in SvelteKit. But most of these snippets have no TS-specific syntax, so it might be better to switch to a shared filename.(js|ts) snippet

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm realizing, we're a bit inconsistent with the languages and even diverge a bit. I'll dedupe the snippets.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened an additional PR because I streamlined some other things while removing the TS stuff: #11038

@Lms24 Lms24 force-pushed the lms/feat-sveltekit-wrapServerRouteWithSentry-docs branch from c603942 to e76bb5f Compare August 9, 2024 09:18
@Lms24 Lms24 merged commit 96d0b78 into master Aug 9, 2024
9 checks passed
@Lms24 Lms24 deleted the lms/feat-sveltekit-wrapServerRouteWithSentry-docs branch August 9, 2024 11:21
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants