ref: Refactor changelog list page #11019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lforst
force-pushed
the
lforst-refactor-changelog-list-page
branch
from
bb10a47
to
dcf71f3
Compare
Bundle ReportChanges will decrease total bundle size by 15 bytes ⬇️
|
chargome
approved these changes
Aug 8, 2024
| }); | ||
|
|
||
| const changelogsWithMdxSummaries = await startSpan( | ||
| {name: 'serialize changelog summaries'}, |
Comment on lines
+2
to
+7
| const now = new Date(date).toLocaleDateString('en-EN', { | ||
| year: 'numeric', | ||
| month: 'long', | ||
| day: 'numeric', | ||
| timeZone: 'UTC' | ||
| }; | ||
| const now = new Date(date).toLocaleDateString('en-EN', options); | ||
| }); |
There was a problem hiding this comment.
l: we could reuse this formatting, or maybe just use day.js?
There was a problem hiding this comment.
I think this is slimmer for now!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"cleans up" the changelog list page. This is all a goal to remove hydration errors.