Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(changelog): Add dotenv-cli as dev dependency #11028

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Aug 8, 2024

yarn migrate:dev fails because dotenv is not available, dotenv-cli as a dev dependency makes it work.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@Dav1dde Dav1dde requested a review from lforst August 8, 2024 08:51
Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 9:22am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 9:22am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 9:22am

@Dav1dde Dav1dde self-assigned this Aug 8, 2024
@Dav1dde Dav1dde changed the title ref(changelog): Add dotenv-cli as dev dependency fix(changelog): Add dotenv-cli as dev dependency Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Bundle Report

Changes will decrease total bundle size by 11 bytes ⬇️

Bundle name Size Change
sentry-docs-server 8.25MB 2 bytes ⬇️
sentry-docs-edge-server 253.05kB 3 bytes ⬇️
sentry-docs-client 6.24MB 6 bytes ⬇️

@Dav1dde Dav1dde enabled auto-merge (squash) August 8, 2024 09:15
@Dav1dde Dav1dde merged commit 20f3e45 into master Aug 8, 2024
9 checks passed
@Dav1dde Dav1dde deleted the dav1d/changelog-dotenv branch August 8, 2024 09:22
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants