Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DisableUnobservedTaskExceptionCapture method name #11047

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

xt0rted
Copy link
Contributor

@xt0rted xt0rted commented Aug 9, 2024

DESCRIBE YOUR PR

The DisableTaskUnobservedTaskExceptionCapture method was deprecated a few years ago1 in favor of DisableUnobservedTaskExceptionCapture, which was removed around 9 months ago2 for v4.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Footnotes

  1. https://github.com/getsentry/sentry-dotnet/pull/2034

  2. https://github.com/getsentry/sentry-dotnet/pull/2841

Copy link

vercel bot commented Aug 9, 2024

@xt0rted is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@vivianyentran
Copy link
Contributor

@bitsandfoxes Can you help review?

Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 11:25am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 11:25am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Aug 28, 2024 11:25am

@bitsandfoxes bitsandfoxes merged commit 1bca2aa into getsentry:master Aug 28, 2024
10 checks passed
@xt0rted xt0rted deleted the patch-1 branch August 29, 2024 02:43
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants