Fix wrong operator spacing in docs #11052
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
I noticed what appeared to be a double space after the
=
in the example at https://docs.sentry.io/platforms/python/migration/1.x-to-2.x#scope-configuringUpon further inspection, this turned out to be an extra padding that was introduced in:
The passing was supposed to only apply to the
+
/-
at the beginning of a diff line, but it's actually applied to all operators.This PR attempts to apply the the change only to the
+
/-
by using a more specific CSS selector.I'm not sure I got the syntax right though, and there is no CI that builds the doc on forks, so I'm opening a draft PR here to test. The idea is that the
+
/-
are the first children in aspan
with classdiff-inserted
ordiff-deleted
.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES