Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix space typo after beforeSend on line 11 #11060

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ntochi
Copy link

@ntochi ntochi commented Aug 12, 2024

Typo on Docs:
"For example, to get the eventId, you can use beforeSendor the return value of the method capturing an event."

Fix:
"For example, to get the eventId, you can use beforeSend or the return value of the method capturing an event.

Screenshot 2024-08-12 at 11 07 07 AM

IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • [x ] None: Not urgent, can wait up to 1 week+

Typo on Docs: 
"For example, to get the eventId, you can use beforeSendor the return value of the method capturing an event."

Fix:
"For example, to get the eventId, you can use beforeSend or the return value of the method capturing an event.
Copy link

vercel bot commented Aug 12, 2024

@ntochi is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 5:29pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 5:29pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 5:29pm

@vivianyentran
Copy link
Contributor

@a-hariti Do you know if this issue has been fixed already or do we still need this PR as a fix?

@getsantry
Copy link
Contributor

getsantry bot commented Sep 17, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry
Copy link
Contributor

getsantry bot commented Oct 10, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Oct 10, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Nov 2, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants