Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make transition smoother for thirdPartyErrorFilterIntegration paragraph #11061

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Aug 12, 2024

DESCRIBE YOUR PR

It seems like these docs didn't read well enough because @nikolovlazar had issues with them: getsentry/sentry-javascript#13326

This attempts to make the transition between paragraphs a bit smooter.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 3:55pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 3:55pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 3:55pm

Copy link

codecov bot commented Aug 12, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes ⬇️

Bundle name Size Change
sentry-docs-server 8.24MB 6 bytes ⬇️
sentry-docs-edge-server 254.16kB 3 bytes ⬇️
sentry-docs-client 6.25MB 6 bytes ⬇️

@lforst lforst changed the title Note that thirdPartyErrorFilterIntegration is not supported with Loader or CDN bundles Make transition smoother for thirdPartyErrorFilterIntegration paragraph Aug 12, 2024
Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for editing this!

@vivianyentran vivianyentran merged commit 25a5c4b into master Aug 26, 2024
9 checks passed
@vivianyentran vivianyentran deleted the lforst-clarify-tpei branch August 26, 2024 18:10
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants