Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Symfony/Monolog PSR3 information #11063

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Aug 12, 2024

DESCRIBE YOUR PR

There's no need to manually register the PsrLogMessageProcessor, this is done automatically since symfony/monolog-bundle@8f00123 . It's enabled by default, but can be disabled by setting the process_psr_3_messages option to false.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Aug 12, 2024

@HypeMC is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 5:30pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 5:30pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 5:30pm

@vivianyentran
Copy link
Contributor

@cleptric Can you help review?

@getsantry
Copy link
Contributor

getsantry bot commented Sep 17, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Sep 17, 2024
@HypeMC
Copy link
Contributor Author

HypeMC commented Sep 17, 2024

Please don't close 😄

@lizokm
Copy link
Contributor

lizokm commented Sep 17, 2024

@cleptric Hi Michi, would love your eyes on this when you have time <3

@cleptric cleptric merged commit d4c5d8a into getsentry:master Sep 20, 2024
10 checks passed
@HypeMC HypeMC deleted the symfony-psr3 branch September 20, 2024 22:34
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants