Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add allowUrls and denyUrls for Flutter #11067

Merged

Conversation

martinhaintz
Copy link
Collaborator

DESCRIBE YOUR PR

Added allowUrls and denyUrls for Flutter, which is implemented in this PR: 2227

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Aug 13, 2024

@martinhaintz is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 3:56pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 3:56pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 3:56pm

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding!
@buenaflor Can you help review the code samples?

docs/platforms/flutter/configuration/filtering.mdx Outdated Show resolved Hide resolved
docs/platforms/flutter/configuration/filtering.mdx Outdated Show resolved Hide resolved
docs/platforms/flutter/configuration/filtering.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments about the code snippet

platform-includes/configuration/allow-urls/dart.mdx Outdated Show resolved Hide resolved
platform-includes/configuration/deny-urls/dart.mdx Outdated Show resolved Hide resolved
@martinhaintz martinhaintz marked this pull request as ready for review October 1, 2024 13:16
@buenaflor
Copy link
Contributor

cc @kahest need a ci re-deploy pls

@martinhaintz martinhaintz merged commit 60950b4 into getsentry:master Oct 16, 2024
10 checks passed
@martinhaintz martinhaintz deleted the support-allow-urls-deny-urls-dart branch October 16, 2024 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants