Add http breadcrumb level based on response code
#11083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
lforst
reviewed
Aug 14, 2024
Comment on lines
+272
to
+273
| - `warning` - response status code 4XX | ||
| - `error` - response status code 5XX |
There was a problem hiding this comment.
I am not totally sold on 4xx being a warning. 4xx is equally as bad from the client perspective as 5xx. (if not worse, because you are actually on the client)
vivianyentran
approved these changes
Aug 26, 2024
|
This is in-line with https://develop.sentry.dev/sdk/features/#http-client-errors, if you feel strongly about this, we can make this configurable in certain SDKs. |
|
@cleptric you're probably right, we can do warnings |
lforst
approved these changes
Sep 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See getsentry/team-sdks#100