-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(discover-split): Update Discover, Alerts, Dashboards docs #11101
Conversation
In preparation for the dataset split in discover and dashboards, we need to update the docs to reflect this new change. The changes typically involve removing `event.type:error` or `event.type:transaction` from being mentioned in search fields because after the dataset is selected, these are redundant. It also updates screenshots and calls out the dataset selector more explicitly.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 15 bytes ⬇️
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should split up this section
https://github.com/getsentry/sentry-docs/pull/11101/files#diff-0df0e661cacec6f97cfe0bc85f38b934a830010696797fbb2f93c927627af7e5R53 into explicit Errors and Transactions?
Can we also get @lizokm or someone from docs to review this?
I was thinking about that as well, I tried to split them apart but I found myself duplicating the portion about being able to query for this data in Discover. I'll look at fleshing out the meaning of the datasets more and that should make it easier to split the sections. |
@narsaynorath thanks for updating. I will take a look at this tomorrow! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these updates!
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
@narsaynorath should we merge this? |
In preparation for the dataset split in discover and dashboards, we need to update the docs to reflect this new change.
The changes typically involve removing
event.type:error
orevent.type:transaction
from being mentioned in search fields because after the dataset is selected, these are redundant. It also updates screenshots and calls out the dataset selector more explicitly.