Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add favicon to app dir #11112

Merged
merged 1 commit into from
Aug 16, 2024
Merged

fix: add favicon to app dir #11112

merged 1 commit into from
Aug 16, 2024

Conversation

chargome
Copy link
Member

should add favicon to production deployment

@chargome chargome self-assigned this Aug 16, 2024
Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 8:50am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 8:50am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 8:50am

Copy link

codecov bot commented Aug 16, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes ⬇️

Bundle name Size Change
sentry-docs-server 8.25MB 6 bytes ⬇️
sentry-docs-edge-server 254.34kB 3 bytes ⬇️
sentry-docs-client 6.25MB 6 bytes ⬇️

Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

Let's also remove the icons from/public and the code that switches favicons when in production mode, otherwise it's confusing.

Also please record that fact in the commit message.

@chargome
Copy link
Member Author

note: will do the cleanup in a follow-up PR, if the changes work as expected on sentry.io/changelog

@chargome chargome merged commit 475378e into master Aug 16, 2024
9 checks passed
@chargome chargome deleted the cg/fix-changelog-favicon branch August 16, 2024 08:56
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants