feat: Giscus comments based on GH discussions #11132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 58.66kB ⬆️
|
|
Does that include iframes @Jeffreyhung ? |
|
@a-hariti iframe is a common way that drops 3rd party cookies, but it doesn't necessary do so |
|
It does drop these cookies, the question is does the no cookie policy cover iframes or not? 
|
|
Cancelling this due to cookie policy |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable users to login with GH account and leave comments on docs,
which will show up under the repo discussions and on the docs page ofc.
Setup guide: https://giscus.app: basically install the Giscus app and enable Discussions
Currently I have it setup to my personal fork for the preview
TODO: