Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): Rename CJS to ESM #11139

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix(node): Rename CJS to ESM #11139

merged 1 commit into from
Aug 26, 2024

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Aug 26, 2024

DESCRIBE YOUR PR

Renames "CJS" to "ESM" in "ESM" paragraph.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 8:02am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 8:02am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Aug 26, 2024 8:02am

Copy link

codecov bot commented Aug 26, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes ⬇️

Bundle name Size Change
sentry-docs-server 8.25MB 6 bytes ⬇️
sentry-docs-edge-server 254.34kB 3 bytes ⬇️
sentry-docs-client 6.25MB 6 bytes ⬇️

@s1gr1d s1gr1d merged commit 2d3a737 into master Aug 26, 2024
9 checks passed
@s1gr1d s1gr1d deleted the sig/cjs-esm branch August 26, 2024 08:18
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants