-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nestjs): Update nestjs error monitoring setup #11141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 15 bytes ⬇️
|
lforst
approved these changes
Aug 26, 2024
@@ -35,6 +33,45 @@ import { AppService } from './app.service'; | |||
export class AppModule {} | |||
``` | |||
|
|||
In case you are using a global catch-all exception filter (which is either a filter registered with | |||
`app.useGlobalFilters()` or a filter registered in your app module providers annotated with an empty `@Catch()` decorator), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
`app.useGlobalFilters()` or a filter registered in your app module providers annotated with an empty `@Catch()` decorator), | |
`app.useGlobalFilters()` or a filter registered in your app module providers annotated with a `@Catch()` decorator without arguments), |
Comment on lines
38
to
39
add a `@WithSentry()` decorator to the `catch()` method of this global error filter. This decorator will report all | ||
unexpected errors that are received by your global error filter to Sentry: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
add a `@WithSentry()` decorator to the `catch()` method of this global error filter. This decorator will report all | |
unexpected errors that are received by your global error filter to Sentry: | |
add a `@WithSentry()` decorator to the `catch()` method of this global error filter. This decorator will report all | |
unexpected errors to Sentry that are received by your global error filter: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates nestjs documentation with a new setup introduced in 8.27. Users now need to manually either add the
SentryGlobalFilter
or decorate existing global error handlers.Note: Should be merged after 8.27 is released.