Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiling): add sample format V2 documentation #11150

Merged
merged 11 commits into from
Sep 3, 2024

Conversation

viglia
Copy link
Contributor

@viglia viglia commented Aug 27, 2024

DESCRIBE YOUR PR

Add documentation for profile sample format version 2.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.): 2024-09-03
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

add page for sample format V2
Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 6:53am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 6:53am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 6:53am

@viglia viglia requested a review from phacops August 29, 2024 15:44
Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions

develop-docs/sdk/telemetry/profiles/sample-format-v1.mdx Outdated Show resolved Hide resolved
develop-docs/sdk/telemetry/profiles/sample-format-v1.mdx Outdated Show resolved Hide resolved
develop-docs/sdk/telemetry/profiles/sample-format-v1.mdx Outdated Show resolved Hide resolved
develop-docs/sdk/telemetry/profiles/sample-format-v1.mdx Outdated Show resolved Hide resolved
develop-docs/sdk/telemetry/profiles/sample-format-v1.mdx Outdated Show resolved Hide resolved
develop-docs/sdk/telemetry/profiles/sample-format-v1.mdx Outdated Show resolved Hide resolved
develop-docs/sdk/telemetry/profiles/sample-format-v1.mdx Outdated Show resolved Hide resolved
@viglia viglia merged commit 0960ed0 into master Sep 3, 2024
9 checks passed
@viglia viglia deleted the viglia/ref/add-sample-format-v2-doc branch September 3, 2024 15:13
Zylphrex pushed a commit that referenced this pull request Sep 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants