Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto include SignInNote #11151

Merged
merged 2 commits into from
Aug 28, 2024
Merged

feat: auto include SignInNote #11151

merged 2 commits into from
Aug 28, 2024

Conversation

a-hariti
Copy link
Collaborator

@a-hariti a-hariti commented Aug 27, 2024

closes #7741

an LGTM basically means things look like they used to 😄

Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 11:47am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 11:47am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Aug 27, 2024 11:47am

Copy link

codecov bot commented Aug 27, 2024

Bundle Report

Changes will increase total bundle size by 541 bytes ⬆️

Bundle name Size Change
sentry-docs-server 8.26MB 238 bytes ⬆️
sentry-docs-edge-server 254.34kB 3 bytes ⬇️
sentry-docs-client 6.26MB 306 bytes ⬆️

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor 👍

I was just wondering why develop-docs was skipped on this one since we had component changes?

@a-hariti
Copy link
Collaborator Author

yeah, not sure why it was skipped :\

@a-hariti a-hariti merged commit 5fa1e26 into master Aug 28, 2024
10 checks passed
@a-hariti a-hariti deleted the auto-singin-note branch August 28, 2024 11:43
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SignInNote should be rendered via CodeBlock
2 participants