Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove incorrect mention of tracing on Dramatiq docs #11152

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Aug 27, 2024

DESCRIBE YOUR PR

The Dramatiq integration docs page states that the Dramatiq integration supports tracing, but it only supports errors.

This change corrects the page accordingly.

Fixes #11143

IS YOUR CHANGE URGENT?

Would be good to merge sooner rather than later since this PR corrects incorrect information in our docs. There is no specific deadline, though.

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

The Dramatiq integration docs page states that the Dramatiq integration supports tracing, but it only supports errors.

This change corrects the page accordingly.

Fixes #11143
@szokeasaurusrex szokeasaurusrex requested review from sentrivana and a team August 27, 2024 11:41
Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 0:01am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 0:01am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 0:01am

Copy link

codecov bot commented Aug 27, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes ⬇️

Bundle name Size Change
sentry-docs-server 8.26MB 6 bytes ⬇️
sentry-docs-edge-server 254.34kB 3 bytes ⬇️
sentry-docs-client 6.26MB 6 bytes ⬇️

Comment on lines 6 to 10
The Dramatiq integration adds support for the
[Dramatiq](https://dramatiq.io/) background tasks library.

The Dramatiq integration only reports errors. Tracing is not yet supported.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Dramatiq integration adds support for the
[Dramatiq](https://dramatiq.io/) background tasks library.
The Dramatiq integration only reports errors. Tracing is not yet supported.
The Dramatiq integration adds support for the
[Dramatiq](https://dramatiq.io/) background tasks library. At this time, this integration only supports errors. Tracing is not yet supported.

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) August 28, 2024 11:43
@szokeasaurusrex szokeasaurusrex merged commit 91c7770 into master Aug 28, 2024
10 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/dramatiq branch August 28, 2024 12:01
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DramatiqIntegration does not support tracing
4 participants