-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Remove incorrect mention of tracing on Dramatiq docs #11152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dramatiq integration docs page states that the Dramatiq integration supports tracing, but it only supports errors. This change corrects the page accordingly. Fixes #11143
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 15 bytes ⬇️
|
sentrivana
approved these changes
Aug 27, 2024
lizokm
reviewed
Aug 27, 2024
Comment on lines
6
to
10
The Dramatiq integration adds support for the | ||
[Dramatiq](https://dramatiq.io/) background tasks library. | ||
|
||
The Dramatiq integration only reports errors. Tracing is not yet supported. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
The Dramatiq integration adds support for the | |
[Dramatiq](https://dramatiq.io/) background tasks library. | |
The Dramatiq integration only reports errors. Tracing is not yet supported. | |
The Dramatiq integration adds support for the | |
[Dramatiq](https://dramatiq.io/) background tasks library. At this time, this integration only supports errors. Tracing is not yet supported. | |
lizokm
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating!
Co-authored-by: Stephanie Anderson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
The Dramatiq integration docs page states that the Dramatiq integration supports tracing, but it only supports errors.
This change corrects the page accordingly.
Fixes #11143
IS YOUR CHANGE URGENT?
Would be good to merge sooner rather than later since this PR corrects incorrect information in our docs. There is no specific deadline, though.
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: