Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Document sys.exit integration #11153

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Aug 27, 2024

Converted to draft pending release of the integration. Add the version number that the integration was released in prior to merge.

DESCRIBE YOUR PR

Add documentation for the sys.exit integration, introduced in getsentry/sentry-python#3401.

Closes #11043

IS YOUR CHANGE URGENT?

None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 7:16am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 7:16am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 7:16am

Add documentation for the sys.exit integration, introduced in getsentry/sentry-python#3401.

Closes #11043
Copy link

codecov bot commented Aug 27, 2024

Bundle Report

Changes will increase total bundle size by 189 bytes ⬆️

Bundle name Size Change
sentry-docs-server 8.26MB 198 bytes ⬆️
sentry-docs-edge-server 254.34kB 3 bytes ⬇️
sentry-docs-client 6.26MB 6 bytes ⬇️

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding this!

docs/platforms/python/integrations/sys_exit/index.mdx Outdated Show resolved Hide resolved
docs/platforms/python/integrations/sys_exit/index.mdx Outdated Show resolved Hide resolved
@szokeasaurusrex
Copy link
Member Author

thanks for the suggestions @vivianyentran!

@szokeasaurusrex szokeasaurusrex marked this pull request as draft August 30, 2024 07:00
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review September 9, 2024 11:31
@szokeasaurusrex szokeasaurusrex merged commit e8ab62d into master Sep 9, 2024
10 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/sys-exit branch September 9, 2024 11:32
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Python's SysExitIntegration
3 participants