-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Upgrade codecov bundle analysis plugins to 1.0.0 #11306
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks for bumping sentry as well!
edit: just noticed that the changelog deployment failed due to a webpack error
Bundle ReportChanges will increase total bundle size by 138.95kB (0.99%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Yes, not sure why this is happening. I reverted this in e906da4, and will follow up to investigate further later on. |
DESCRIBE YOUR PR
Bundle analysis for codecov has hit 1.0.0, so upgrading the plugins in the docs repo so we can test.
To accommodate this change, we switch from using the regular webpack plugin, to the nextjs specific codecov webpack plugin: https://github.com/codecov/codecov-javascript-bundler-plugins/tree/main/packages/nextjs-webpack-plugin
While I'm here I also bumped the sentry nextjs sdk version.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES