Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(react): Add error boundary docs for react-router #11326

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

chargome
Copy link
Member

Add docs for error boundaries in react router.

closes #9337

@chargome chargome self-assigned this Sep 11, 2024
Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 1:58pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 1:58pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 1:58pm

Copy link

codecov bot commented Sep 11, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.43MB 6 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 257.01kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.4MB 6 bytes (-0.0%) ⬇️

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few language suggestions :)

@Zwyx
Copy link

Zwyx commented Sep 20, 2024

Thank you for doing this! Maybe you could add a note about the fact that this solution doesn't allow the use of Sentry's dialog (as mentioned here: #9337 (comment) )

@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete React Router documentation
5 participants